1352608 - FennecTabsRepository's getLocalClientLastModified leaves an open cursor

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[:Grisha Kruglov]

Introduced in Bug 1265314.

Comment 1

[:Grisha Kruglov]

Attachment: Bug 1352608 - Close a cursor after we're done with it

Removed "final" because "safeQuery" provides terrible developer ergonomics.

Review commit: https://reviewboard.mozilla.org/r/125666/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125666/

Comment 2

[Edouard Oger [:eoger]]

Comment on attachment 8853589 [details]
Bug 1352608 - Close a cursor after we're done with it

https://reviewboard.mozilla.org/r/125666/#review128250

shipit.exe

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/698b0748f7f7
Close a cursor after we're done with it r=eoger

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/698b0748f7f7

Comment 5

[Edouard Oger [:eoger]]

Comment on attachment 8853589 [details]
Bug 1352608 - Close a cursor after we're done with it

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1265314
[User impact if declined]: We might leak some memory
[Is this code covered by automated tests?]: -
[Has the fix been verified in Nightly?]: -
[Needs manual test from QE? If yes, steps to reproduce]: -
[List of other uplifts needed for the feature/fix]: -
[Is the change risky?]: Not at all
[Why is the change risky/not risky?]: We are only closing a cursor.
[String changes made/needed]: -

Comment 6

[Gerry Chang [:gchang]]

Comment on attachment 8853589 [details]
Bug 1352608 - Close a cursor after we're done with it

Required by bug 1265314. Aurora54+.

Comment 7

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ad01b1eb62fc