Closed Bug 1352688 Opened 8 years ago Closed 8 years ago

Incorrect collectionView size for TopSites in AS

Categories

(Firefox for iOS :: Home screen, enhancement, P1)

Product:
Firefox for iOS
Component:
Home screen
Platform:
Other
iOS
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Iteration:
1.19
Tracking Flags:
Tracking Status
fxios 8.0+ ---
fxios-v8.0 --- verified

People

(Reporter: farhan, Assigned: farhan)

Details

(Whiteboard: [mobileAS])

Attachments

(1 file)

Pull Request
55 bytes, text/x-github-pull-request
bmunar
: review+
Details | Review
The Topsites section in AS has incorrect height when there is more than 1 page which results in being able to scroll vertically inside the TopSites section which should not be possible.
Assignee: nobody → fpatel
Iteration: --- → 1.19
tracking-fxios: --- → 8.0+
Whiteboard: [mobileAS]
Priority: -- → P1
Attached file Pull Request —
Attachment #8853744 - Flags: review?(bmunar)
Attachment #8853744 - Flags: review?(bmunar) → review+
master https://github.com/mozilla-mobile/firefox-ios/commit/9f913780eed0842c78c840a2b7a4afae96d59cac
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Verifying as fix on master b3b12590bebb48. Vertical scrolling inside the Top Sites section is no longer possible.
Status: RESOLVED → VERIFIED
status-fxios-v8.0: --- → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: