Closed
Bug 1352849
Opened 7 years ago
Closed 7 years ago
Enable SafeBrowsing v4 tables on SeaMonkey nightly builds
Categories
(SeaMonkey :: Security, enhancement)
SeaMonkey
Security
Tracking
(seamonkey2.49esr unaffected, seamonkey2.50 wontfix, seamonkey2.51 wontfix, seamonkey2.52 fixed)
RESOLVED
FIXED
seamonkey2.52
| Tracking | Status | |
|---|---|---|
| seamonkey2.49esr | --- | unaffected |
| seamonkey2.50 | --- | wontfix |
| seamonkey2.51 | --- | wontfix |
| seamonkey2.52 | --- | fixed |
People
(Reporter: rsx11m.pub, Assigned: rsx11m.pub)
Details
Attachments
(1 file)
|
1.66 KB,
patch
|
frg
:
review+
|
Details | Diff | Splinter Review |
Needs additional preferences per Core bug 1305486.
Direct port of mozilla-central changeset ca2fd69cb777. I've put it closer to the other SafeBrowsing preferences though and used "#if defined()" given the overall style in this file (though I'd think it's exactly the same as "#ifdef"). Asking frg for review as offered, IanN can then approve for branches where needed.
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8853774 [details] [diff] [review] Simple patch >> #if defined()" given the overall style in this file (though I'd think it's >> exactly the same as "#ifdef" As far as I know "if defined" tests for existance and true. "ifdef" only for existance. NIGHTLY_BUILD is defined as 1 so either one is fine here.
Attachment #8853774 -
Flags: review?(frgrahl) → review+
Thanks, so let's keep it the same as for all other occurrences in this file. Pushed to trunk as https://hg.mozilla.org/comm-central/rev/0ca38f8b1d1b Do we need this on any of the branches as well or just comm-central?
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: needinfo?(frgrahl)
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.52
|
|
||
Comment 4•7 years ago
|
||
I think it can ride the trains. Merge day isn't far away and aurora doesn't define NIGHTLY_BUILD anyway.
Flags: needinfo?(frgrahl)
Ok, setting flags respectively.
status-seamonkey2.50:
--- → wontfix
status-seamonkey2.51:
--- → wontfix
status-seamonkey2.52:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•