1352977 - Needs utilities to create font.name(-list).* pref names

Status: RESOLVED FIXED

(Core :: Graphics: Text, enhancement, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

In a lot of places, gfx code creates a pref name of font.name.* and font.name-list.*.

I think that there should be:

gfxFontNamePrefName : public nsAutoCString
{
public:
  gfxFontNamePrefName(const nsACString& aGenericFamily,
                      const nsACString& aLangGroup);
  gfxFontNamePrefName(const nsACString& aGenericFamily,
                      const nsIAtom& aLangGroup);
}

gfxFontNameListPrefName : public nsAutoCString
{
public:
  gfxFontNameListPrefName(const nsACString& aGenericFamily,
                          const nsACString& aLangGroup);
  gfxFontNameListPrefName(const nsACString& aGenericFamily,
                          const nsIAtom& aLangGroup);
};

Any ideas? Just should be methods to modify nsAutoCString?

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Factor out helpers to construct the names for generic- and language-dependent font/font-list preferences

I suggest we do something like this... wdyt?

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8856507 [details] [diff] [review]
Factor out helpers to construct the names for generic- and language-dependent font/font-list preferences

Ah, template. Looks great!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/04af8016735f
Factor out helpers to construct the names for generic- and language-dependent font/font-list preferences. r=masayuki

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/04af8016735f