1353019 - Custom tabs: reload/refresh button from menu doesn't change to "x"

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Sorina Florean [:sflorean]]

Attachment: Screenshot_2017-04-03-17-29-01.png

Environment: 
Device: Huawei Honor (Android 5.1.1);
Build: Nightly 55.0a1 (2017-04-02);

Steps to reproduce:
1. Open a web page by custom tabs;
2. Tap on three dots menu while page is loading.

Expected result:
While page is loading the reload/refresh button from three-dots-menu is "x" meaning stop loading/downloading.

Actual result:
Reload/refresh button remains the same.

Comment 1

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

P2 per triage on april12

Comment 2

[Julian Chu [:walkingice]]

Attachment: Bug 1353019: fix icon creation issue in GeckoMenuItem

If change icon via resource id, we should create mIcon as well. And
method `getIcon` should return the drawable which be used currently, but
not generating a new drawable via resource id.

Without this patch, we cannot change icon of a GeckoMenuItem until we
set the icon back. ie.

    Drawable icon = menuItem.getIcon();
    icon.setLevel(42); // does not work, cause the icon is new instance.

Review commit: https://reviewboard.mozilla.org/r/131512/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131512/

Comment 3

[Julian Chu [:walkingice]]

Attachment: Bug 1353019: update menu icon of CustomTabsActivity as per page loading

There is a control in menu for reloading or stop-page-loading. Its icon
should be updated per page loading progress.

Review commit: https://reviewboard.mozilla.org/r/131514/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131514/

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8859507 [details]
Bug 1353019: fix icon creation issue in GeckoMenuItem

https://reviewboard.mozilla.org/r/131512/#review134272

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8859508 [details]
Bug 1353019: update menu icon of CustomTabsActivity as per page loading

https://reviewboard.mozilla.org/r/131514/#review134282

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a01b1efbfe5d
fix icon creation issue in GeckoMenuItem r=sebastian
https://hg.mozilla.org/integration/autoland/rev/175c51c7fe7e
update menu icon of CustomTabsActivity as per page loading r=sebastian

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a01b1efbfe5d
https://hg.mozilla.org/mozilla-central/rev/175c51c7fe7e

Comment 8

[Sorina Florean [:sflorean]]

Verified as fixed on latest Nightly 55.0a1 (2017-05-08).
Device: Honor 8 (Android 6.0)and Asus ZenPad 8(Android 6.0.1).