Closed Bug 1353019 Opened 3 years ago Closed 3 years ago

Custom tabs: reload/refresh button from menu doesn't change to "x"

Categories

(Firefox for Android :: General, defect, P2)

55 Branch
ARM
Android
defect

Tracking

()

VERIFIED FIXED
Firefox 55
Tracking Status
firefox55 --- verified

People

(Reporter: sflorean, Assigned: walkingice)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Environment: 
Device: Huawei Honor (Android 5.1.1);
Build: Nightly 55.0a1 (2017-04-02);

Steps to reproduce:
1. Open a web page by custom tabs;
2. Tap on three dots menu while page is loading.

Expected result:
While page is loading the reload/refresh button from three-dots-menu is "x" meaning stop loading/downloading.

Actual result:
Reload/refresh button remains the same.
Assignee: nobody → walkingice0204
P2 per triage on april12
Priority: -- → P2
Comment on attachment 8859507 [details]
Bug 1353019: fix icon creation issue in GeckoMenuItem

https://reviewboard.mozilla.org/r/131512/#review134272
Attachment #8859507 - Flags: review?(s.kaspari) → review+
Comment on attachment 8859508 [details]
Bug 1353019: update menu icon of CustomTabsActivity as per page loading

https://reviewboard.mozilla.org/r/131514/#review134282
Attachment #8859508 - Flags: review?(s.kaspari) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a01b1efbfe5d
fix icon creation issue in GeckoMenuItem r=sebastian
https://hg.mozilla.org/integration/autoland/rev/175c51c7fe7e
update menu icon of CustomTabsActivity as per page loading r=sebastian
Keywords: checkin-needed
Verified as fixed on latest Nightly 55.0a1 (2017-05-08).
Device: Honor 8 (Android 6.0)and Asus ZenPad 8(Android 6.0.1).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.