1353030 - cleanup and document WrapRunnable uses

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, enhancement, P2)

Description

[Randell Jesup [:jesup] (needinfo me)]

Just documenting WrapRunnable(this, ...) uses; there's one in gmp that due to paranoia I want to wrap, though it's only used for force-crashing GMP instances.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: document use of WrapRunnable(this)

MozReview-Commit-ID: Fb3KjsI9tE3

Comment 2

[Chris Pearce [:cpearce (GMT+13)]]

Comment on attachment 8854008 [details] [diff] [review]
document use of WrapRunnable(this)

Review of attachment 8854008 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/gmp/GMPServiceParent.cpp
@@ +273,5 @@
>            MutexAutoLock lock(mMutex);
>            gmpThread = mGMPThread;
>          }
>          if (gmpThread) {
> +          gmpThread->Dispatch(WrapRunnable(RefPtr<GeckoMediaPluginServiceParent>(this),

I'd point out that the GeckoMediaPluginServiceParent singleton is kept alive by a static refptr that is only cleared in the final stage of shutdown after everything else is shutdown:
https://dxr.mozilla.org/mozilla-central/rev/38894655c89e68bcd8f45d31a0d3005f2c2b53db/dom/media/gmp/GMPService.cpp#123

So while I think the refcount here is a good idea for future-proofing the code, I think it's unlikely it will actually prevent any problems.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/39f8ae0ea97f
document use of WrapRunnable(this) r=cpearce

Comment 4

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/39f8ae0ea97f