Closed
Bug 1353030
Opened 8 years ago
Closed 8 years ago
cleanup and document WrapRunnable uses
Categories
(Core :: Audio/Video: GMP, enhancement, P2)
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: jesup, Assigned: jesup)
Details
Attachments
(1 file)
4.93 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
Just documenting WrapRunnable(this, ...) uses; there's one in gmp that due to paranoia I want to wrap, though it's only used for force-crashing GMP instances.
Assignee | ||
Updated•8 years ago
|
Rank: 22
Assignee | ||
Comment 1•8 years ago
|
||
MozReview-Commit-ID: Fb3KjsI9tE3
Attachment #8854008 -
Flags: review?(cpearce)
Comment 2•8 years ago
|
||
Comment on attachment 8854008 [details] [diff] [review]
document use of WrapRunnable(this)
Review of attachment 8854008 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/media/gmp/GMPServiceParent.cpp
@@ +273,5 @@
> MutexAutoLock lock(mMutex);
> gmpThread = mGMPThread;
> }
> if (gmpThread) {
> + gmpThread->Dispatch(WrapRunnable(RefPtr<GeckoMediaPluginServiceParent>(this),
I'd point out that the GeckoMediaPluginServiceParent singleton is kept alive by a static refptr that is only cleared in the final stage of shutdown after everything else is shutdown:
https://dxr.mozilla.org/mozilla-central/rev/38894655c89e68bcd8f45d31a0d3005f2c2b53db/dom/media/gmp/GMPService.cpp#123
So while I think the refcount here is a good idea for future-proofing the code, I think it's unlikely it will actually prevent any problems.
Attachment #8854008 -
Flags: review?(cpearce) → review+
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/39f8ae0ea97f
document use of WrapRunnable(this) r=cpearce
![]() |
||
Comment 4•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•