Closed
Bug 1353036
Opened 8 years ago
Closed 8 years ago
Update mozscreenshots to use new Preferences categories
Categories
(Firefox :: Settings UI, enhancement)
Tracking
()
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: jaws, Assigned: jaws)
References
Details
Attachments
(1 file)
Since 1335907 introduced new categories for the preferences we will need to update mozscreenshots to use the new preference categories.
See http://searchfox.org/mozilla-central/rev/990055a4902952e038cc350c9ffe1ac426d1c943/browser/tools/mozscreenshots/mozscreenshots/extension/configurations/Preferences.jsm#20-36 for the section that needs to be changed.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8854020 [details]
Bug 1353036 - Update mozscreenshots to use new preference category names and locations.
https://reviewboard.mozilla.org/r/126010/#review131042
::: browser/tools/mozscreenshots/mozscreenshots/extension/configurations/Preferences.jsm:20
(Diff revision 1)
> - ["paneGeneral", null],
> - ["paneSearch", null],
> - ["paneContent", null],
> - ["paneApplications", null],
> + ["paneGeneral"],
> + ["paneApplications"],
> + ["panePrivacy"],
> + ["panePrivacy", DNTDialog],
It seems like we should use Element.scrollIntoView or something like that for the general and privacy panes since we no longer capture the stuff below the fold.
::: browser/tools/mozscreenshots/mozscreenshots/extension/configurations/Preferences.jsm:28
(Diff revision 1)
> - ["paneApplications", null],
> - ["panePrivacy", null],
> - ["panePrivacy", null, DNTDialog],
> - ["panePrivacy", null, clearRecentHistoryDialog],
> - ["paneSecurity", null],
> - ["paneSync", null],
> + ["panePrivacy", DNTDialog],
> + ["panePrivacy", clearRecentHistoryDialog],
> + ["panePrivacy", connectionDialog],
> + ["panePrivacy", certManager],
> + ["panePrivacy", deviceManager],
> + ["paneSync"],
Nit: Move sync up so that the images are in order of the tabs like before.
Comment hidden (mozreview-request) |
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8854020 [details]
Bug 1353036 - Update mozscreenshots to use new preference category names and locations.
https://reviewboard.mozilla.org/r/126010/#review134200
Thanks
::: browser/tools/mozscreenshots/mozscreenshots/extension/configurations/Preferences.jsm:72
(Diff revision 2)
> + if (useOldOrg) {
> + Services.prefs.setBoolPref("browser.preferences.useOldOrganization", true);
> + }
This should be:
```js
Services.prefs.setBoolPref("browser.preferences.useOldOrganization", !!useOldOrg);
```
it just happens to work since all of the first tests pass false followed by all of the true versions.
Attachment #8854020 -
Flags: review?(MattN+bmo) → review+
Comment hidden (mozreview-request) |
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/03cdb9fdd506
Update mozscreenshots to use new preference category names and locations. r=MattN
Comment 7•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in
before you can comment on or make changes to this bug.
Description
•