WasmSignalHandlers.cpp should use __sun instead of SOLARIS

RESOLVED FIXED in Firefox 55

Status

()

Core
JavaScript Engine
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Petr Sumbera, Assigned: Petr Sumbera)

Tracking

52 Branch
mozilla55
Unspecified
Other
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170323105023

Steps to reproduce:

JS build no longer defines SOLARIS macro (this disappeared somewhere between versions 45 and 52).

WasmSignalHandlers.cpp contains one condition where it's really needed and the condition should be probably changed to use pre-defined compiler macro (as it's used there for many other OSes).
(Assignee)

Comment 1

a year ago
Created attachment 8854043 [details] [diff] [review]
Bug1353050.patch
Attachment #8854043 - Flags: review?(luke)

Updated

a year ago
Attachment #8854043 - Flags: review?(luke) → review+

Updated

a year ago
Component: Untriaged → JavaScript Engine
OS: Unspecified → Other
Product: Firefox → Core
(Assignee)

Updated

a year ago
Keywords: checkin-needed
Assignee: nobody → petr.sumbera

Comment 2

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/054b05e1b8f7
WasmSignalHandlers.cpp should use __sun instead of SOLARIS. r=luke
Keywords: checkin-needed

Comment 3

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/054b05e1b8f7
Status: UNCONFIRMED → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.