1353055 - Strip 'vars' debugging information when building Fennec --with-gradle

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, enhancement)

Description

[Nick Alexander :nalexander [he/him]]

In Bug 1255914 and the commit message of https://hg.mozilla.org/mozilla-central/rev/61e649e690c9, I observed that the size of the compiled Java code when built --with-gradle is much larger than the size of the compiled Java code when built --without-gradle (i.e., with moz.build).  I think I can explain this now.

In moz.build, we compile with `-g 'source,lines'`, stripping 'vars' information.  See https://dxr.mozilla.org/mozilla-central/rev/38894655c89e68bcd8f45d31a0d3005f2c2b53db/config/android-common.mk#49.

In Gradle, the default is to compile with `-g 'source,lines,vars'`, and all that variable information takes up non-trivial space.

This ticket tracks dropping `'vars'` for non-debug Gradle builds.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1353055 - Strip 'vars' debugging information when building Fennec --with-gradle.

To observe the difference, use `javap -l`.  For example, for
automationRelease and automationDebug built with `./mach gradle clean
app:assembleAutomationRelease app:assembleAutomationDebug`, I see
locally:

$ javap -l objdir-droid/gradle/build/mobile/android/app/intermediates/classes/automation/release/org/mozilla/gecko/home/activitystream/menu/ActivityStreamContextMenu\$1.class
Compiled from "ActivityStreamContextMenu.java"
class org.mozilla.gecko.home.activitystream.menu.ActivityStreamContextMenu$1 extends org.mozilla.gecko.util.UIAsyncTask$WithoutParams<java.lang.Boolean> {
  final android.view.MenuItem val$bookmarkItem;

  final org.mozilla.gecko.home.activitystream.menu.ActivityStreamContextMenu this$0;

  org.mozilla.gecko.home.activitystream.menu.ActivityStreamContextMenu$1(org.mozilla.gecko.home.activitystream.menu.ActivityStreamContextMenu, android.os.Handler, android.view.MenuItem);
    LineNumberTable:
      line 103: 0

  <snip>
}

$ javap -l objdir-droid/gradle/build/mobile/android/app/intermediates/classes/automation/debug/org/mozilla/gecko/home/activitystream/menu/ActivityStreamContextMenu\$1.class
Compiled from "ActivityStreamContextMenu.java"
class org.mozilla.gecko.home.activitystream.menu.ActivityStreamContextMenu$1 extends org.mozilla.gecko.util.UIAsyncTask$WithoutParams<java.lang.Boolean> {
  final android.view.MenuItem val$bookmarkItem;

  final org.mozilla.gecko.home.activitystream.menu.ActivityStreamContextMenu this$0;

  org.mozilla.gecko.home.activitystream.menu.ActivityStreamContextMenu$1(org.mozilla.gecko.home.activitystream.menu.ActivityStreamContextMenu, android.os.Handler, android.view.MenuItem);
    LineNumberTable:
      line 103: 0
    LocalVariableTable:
      Start  Length  Slot  Name   Signature
          0      16     0  this   Lorg/mozilla/gecko/home/activitystream/menu/ActivityStreamContextMenu$1;
          0      16     1 this$0   Lorg/mozilla/gecko/home/activitystream/menu/ActivityStreamContextMenu;
          0      16     2    x0   Landroid/os/Handler;

  <snip>
}

Review commit: https://reviewboard.mozilla.org/r/126130/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126130/

Comment 2

[Andrzej Hunt :ahunt]

Comment on attachment 8854158 [details]
Bug 1353055 - Strip 'vars' debugging information when building Fennec --with-gradle.

https://reviewboard.mozilla.org/r/126130/#review128756

`

Comment 3

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 97ce03b719fd -d a9d111f06a1a: rebasing 386695:97ce03b719fd "Bug 1353055 - Strip 'vars' debugging information when building Fennec --with-gradle. r=ahunt" (tip)
merging mobile/android/app/build.gradle
merging mobile/android/geckoview/build.gradle
merging mobile/android/thirdparty/build.gradle
warning: conflicts while merging mobile/android/app/build.gradle! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8854158 [details]
Bug 1353055 - Strip 'vars' debugging information when building Fennec --with-gradle.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/126130/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eec3bab31260
Strip 'vars' debugging information when building Fennec --with-gradle. r=ahunt

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eec3bab31260