1353066 - "Add new jobs" complains "Error: jsyaml not defined"

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Geoff Brown [:gbrown]]

Just noticed this starting today. When I "Add new jobs" in taskcluster, it seems to fail and briefly displays an error, "Taskcluster: jsyaml not defined".

Comment 1

[Geoff Brown [:gbrown]]

(In reply to Geoff Brown [:gbrown] from comment #0)
> When I "Add new jobs" in taskcluster, it

s/taskcluster/treeherder/

...but I assume the issue is in taskcluster, from the error message.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

It sounds like it's in the TH UI, actually.

Comment 3

[GitHub Autolander Bot]

Attachment: [treeherder] imbstack:move-jsyaml-to-new-way > mozilla:master

Comment 4

[Ed Morley [:emorley]]

Comment on attachment 8854145 [details] [review]
[treeherder] imbstack:move-jsyaml-to-new-way > mozilla:master

Chatted with Cameron about this earlier and he agreed to take the review.

Comment 5

[Cameron Dawson [:camd]]

I'm not able to reproduce this locally at this point.  Bstack: can you try again?

Comment 6

[Ed Morley [:emorley]]

I can still repro.

STR are missing from comment 0, but the ones I tried were:
1) Open a single push on stage (for a push that has a decision task)
2) Use the "add new job" link on the push dropdown thing
3) Wait for the runnable jobs to appear in yellow
4) Select one of those new "fake" jobs
5) Open web console
6) Click the "trigger new jobs" button that appears on the push banner (Note: not in the job details panel below. Not being very familiar with this feature, I first tried pressing retrigger there but it does nothing.)
7) Wait a few seconds until a status message appears in the main UI
8) Look at web console

Expected:
Success status message and no exceptions in the web console

Actual:
Main UI error message says "Taskcluster: jsyaml not defined", and web console has a "Error: jsyaml is not defined" exception.

Comment 7

[Cameron Dawson [:camd]]

Ahh!  OK, yeah, I can repro this now.  I thought it was at the "Add new jobs" point.

Comment 8

[Cameron Dawson [:camd]]

I proposed an alternative solution in the PR.  Bstack says he'll take a look at it today

Comment 9

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/b22616a461b99e773dc514d55abc9b28c9894f36
Bug 1353066 - Make jsyaml available as a service (#2314)

This fixes exceptions when using the "add new jobs" feature.