1353283 - Simplify 'See Also'

Status: RESOLVED DUPLICATE of bug 577847

(bugzilla.mozilla.org :: Bug Creation/Editing, enhancement, P3)

Description

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

As it works now, the 'See Also' field has to have a URL template provided for everything it could link to. As tools and services proliferate, that means a ticket and engineering time for every new bug tracker and github feature exposing a URL.

Let us simplify this:

If a value entered into 'see also' is an integer and a valid bug id in this bugzilla instance, then convert it to a bugzilla link, and set up any relationships needed.

If it is a URL, and it's not a link to a bugzilla bug in this instance, save the URL in the list of see alsos.

If it is a URL and a link to a bugzilla bug in this instance, save the URL and set up relationships between bugs.

Comment 1

[:glob ✱]

(In reply to Emma Humphries ☕️ (she/her) [:emceeaich] (UTC-8) +needinfo me from comment #0)
> If it is a URL, and it's not a link to a bugzilla bug in this instance, save
> the URL in the list of see alsos.

this overlaps with the existing URL field, so it may not be clear to users which field is appropriate.
because of this i quite like the idea that only issue trackers are valid in the 'see also' field.

one way to address this would be to have a whitelist of domains (or regexs?) that are allowed in the 'see also' field, governed by an admin parameter.  we'd retain the existing functionality of only allowing known issue trackers, and the turn around time on adding new trackers would be minimal.

Comment 2

[Dylan Hardison [:dylan] (he/him)]

This would be implemented by a ::Generic BugUrl object that took its regex from a param.
The current (over-engineered) solution is actually useful, should we ever want to start pulling in info from, say, github.

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Implementation: package Bugzilla::BugUrl::Arbitrary, which takes a list of valid domains from an admin paramater
(Bugzilla->params->{see_also_arbitrary_domains})
and if the hostname of a url matches one of the domain, domain _check_value() returns true.

On the admin side, the see_also_arbitrary_domains should validate that domains cannot be removed
while in use. This can be done by searching the bug_see_also table for the class (Bugzilla::BugUrl::Arbitrary).

Comment 5

[:glob ✱]

We're going to fix this in bug 577847 by allowing any URL in see-also.