Closed
Bug 1353353
Opened 9 years ago
Closed 8 years ago
Add GetName and BindName to CacheIR spewer
Categories
(Core :: JavaScript Engine: JIT, enhancement, P3)
Core
JavaScript Engine: JIT
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
9.04 KB,
patch
|
evilpies
:
review+
|
Details | Diff | Splinter Review |
Might reveal something interesting.
|
||
Updated•9 years ago
|
Whiteboard: [qf]
|
|
||
Updated•9 years ago
|
Whiteboard: [qf] → [qf-]
|
Assignee | |
Comment 1•9 years ago
|
||
This patch adds spew for both GetName and BindName.
|
|
Assignee | |
Updated•9 years ago
|
Summary: Add GetName to CacheIR spewer → Add GetName and BindName to CacheIR spewer
|
|
Assignee | |
Comment 2•9 years ago
|
||
Not too surprising but GlobalNameValue is very hot. Also some failures in chrome code, probably from non-syntactic scopes..
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8861398 [details] [diff] [review]
Patch
Review of attachment 8861398 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good. There are various other callers to valueProperty that won't need rooting anymore.
Attachment #8861398 -
Flags: review?(evilpies) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0e067be07c9
Add GetName and BindName CacheIR spew. r=evilpie
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•4 years ago
|
Performance Impact: --- → -
Whiteboard: [qf-]
You need to log in
before you can comment on or make changes to this bug.
Description
•