1353371 - Remove the middleware

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[[DEACTIVATED] Adrian Gaudebert]

Once bug 1188083 is resolved, there won't be any need for the middleware anymore. Let's remove all traces of it! 

I am not sure what this entails, so I'm going to ask for some help here. CC Miles. 

Will told me today we can start by changing this file to make the ExecStart instruction a no-op: https://github.com/mozilla/socorro/blob/master/config/package/usr/lib/systemd/system/socorro-middleware.service

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

I think we can just change the ExecStart to a no-op like "echo" or something. But I could be horribly wrong--maybe systemd keeps tabs on the process and if it ends, then it gets sad and tries to start it again which would be a mess.

Definitely worth working out the plan with Miles. It's entirely possible it's super easy to do on the ops side.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

I logged into a -stage web head and verified that the .service file that runs the middleware is the one we have in the Socorro repo.

I'm going to do a PR that no-ops that service file which will allow us to remove all the middleware code now. Then we can do the infrastructure changes later in a separate bug.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 3822: make the socorro-middleware service a no-op

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/56afa61671128c08feb1d8bb492ec991411bee0d
Bug 1353371 - change middleware service to be a no-op (#3822)

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

I made bug #1375183 to cover removing the infrastructure.

This bug can cover removing the rest of the code since I don't see another bug for that. Given that, I'm going to move it back to General.

Comment 6

[[DEACTIVATED] Adrian Gaudebert]

Attachment: Link to Github pull-request

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/3b49b39ba5a08788bf8ec89df3f08914a3cb8ae7
Fixes bug 1353371 - Removed all remnants of the deceased middleware. (#3826)