1353646 - Bookmarks validator should report "abandoned" items

Status: RESOLVED INVALID

(Firefox :: Sync, enhancement)

Description

[Mark Hammond [:markh] [:mhammond]]

In https://bug1343365.bmoattachments.org/attachment.cgi?id=8842189 we see validation errors like:

"Child record v4OABaB0Cmsv appears as a child in multiple parents" where the parents are listed as uh4d-7M0aNDh and nJLku6FstMQ3. What's strange is that best I can tell, nJLku6FstMQ3 has a record on the server and correctly points at its (supposed) parent - however, it *does not* appear as a child in the parent. The validator should report such items.

You could argue these are orphans, but it might make sense to create a new category for them - eg, "abandoned" - so it's clearer what we are dealing with in our analysis (orphans are defined as "parent missing", this is "parent forgot me"). However, I don't feel too strongly about that - a new category might impact Kit's work too WRT seeing it in redash and if you both argued we should report them as orphans I'd be ok with that.

Thom, can you please have a look at that attachment and verify what I'm saying is true and that it's not already reflected in our validation data?

Comment 1

[Thom Chiovoloni [:tcsc] (ex-moco)]

This is already an existing property: "parentChildMismatches". As far as I can tell, it is being properly detected as well, although maybe I'm mistaken (I don't seem to see any of the same IDs you listed in my validation report on aboutsync -- which could indicate a bug in either aboutsync or the validator).

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Thanks, I think you are correct