Closed Bug 1353693 Opened 6 years ago Closed 6 years ago

Support async generator methods

Categories

(Core :: JavaScript Engine, enhancement)

Product:
Core
Component:
JavaScript Engine
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: anba, Assigned: anba)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 1 obsolete file)

bug1353693.patch
5.85 KB, patch
anba
: review+
Details | Diff | Splinter Review 
Test case:
---
({async* m(){}})
---

Expected: Parses without an exception
Actual: Throws SyntaxError "missing : after property id"
Attached patch bug1353693.patch (obsolete) — — Splinter Review 
I didn't add any tests because the next test262 update will add a few hundred new tests for async generator methods (which all pass with this patch applied).
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8855762 - Flags: review?(arai.unmht)
Comment on attachment 8855762 [details] [diff] [review]
bug1353693.patch

Review of attachment 8855762 [details] [diff] [review]:
-----------------------------------------------------------------

thank you :D
Attachment #8855762 - Flags: review?(arai.unmht) → review+
Attached patch bug1353693.patch — — Splinter Review 
Updated patch to apply clean on inbound, carrying r+.
Attachment #8855762 - Attachment is obsolete: true
Attachment #8856238 - Flags: review+
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3cb1462512b7
Correct parsing of async generator methods. r=arai
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3cb1462512b7
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.