Closed
Bug 1353693
Opened 6 years ago
Closed 6 years ago
Support async generator methods
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 1 obsolete file)
5.85 KB,
patch
|
anba
:
review+
|
Details | Diff | Splinter Review |
Test case: --- ({async* m(){}}) --- Expected: Parses without an exception Actual: Throws SyntaxError "missing : after property id"
Updated•6 years ago
|
Keywords: dev-doc-needed
Assignee | ||
Comment 1•6 years ago
|
||
I didn't add any tests because the next test262 update will add a few hundred new tests for async generator methods (which all pass with this patch applied).
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8855762 -
Flags: review?(arai.unmht)
Comment 2•6 years ago
|
||
Comment on attachment 8855762 [details] [diff] [review] bug1353693.patch Review of attachment 8855762 [details] [diff] [review]: ----------------------------------------------------------------- thank you :D
Attachment #8855762 -
Flags: review?(arai.unmht) → review+
Assignee | ||
Comment 3•6 years ago
|
||
Updated patch to apply clean on inbound, carrying r+.
Attachment #8855762 -
Attachment is obsolete: true
Attachment #8856238 -
Flags: review+
Assignee | ||
Comment 4•6 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f573b326c4edde1d35189ac4c76e7493be39a4ca
Keywords: checkin-needed
Pushed by ihsiao@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3cb1462512b7 Correct parsing of async generator methods. r=arai
Keywords: checkin-needed
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3cb1462512b7
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment 7•6 years ago
|
||
https://developer.mozilla.org/en-US/Firefox/Releases/55#JavaScript https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Method_definitions#Async_generator_methods
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•