1353693 - Support async generator methods

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[André Bargull [:anba]]

Test case:
---
({async* m(){}})
---

Expected: Parses without an exception
Actual: Throws SyntaxError "missing : after property id"

Comment 1

[André Bargull [:anba]]

Attachment: bug1353693.patch

I didn't add any tests because the next test262 update will add a few hundred new tests for async generator methods (which all pass with this patch applied).

Comment 2

[Tooru Fujisawa [:arai]]

Comment on attachment 8855762 [details] [diff] [review]
bug1353693.patch

Review of attachment 8855762 [details] [diff] [review]:
-----------------------------------------------------------------

thank you :D

Comment 3

[André Bargull [:anba]]

Attachment: bug1353693.patch

Updated patch to apply clean on inbound, carrying r+.

Comment 4

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f573b326c4edde1d35189ac4c76e7493be39a4ca

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3cb1462512b7
Correct parsing of async generator methods. r=arai

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3cb1462512b7

Comment 7

[Florian Scholz (Open Web Docs)]

https://developer.mozilla.org/en-US/Firefox/Releases/55#JavaScript
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Method_definitions#Async_generator_methods