1353714 - Crash @ java.lang.NoClassDefFoundError: android.app.ActivityManager$TaskDescription at org.mozilla.gecko.webapps.WebAppActivity.loadManifest(WebAppActivity.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

Description

[Oana Horvath [:ohorvath]]

Build: Nightly 55.0a1 (2017-04-05);
Devices: 
- Lenovo A536 (Android 4.4.2);
- Lenovo Yoga Tablet 2 (Android 4.4.2)

Steps to reproduce:
Install and open a standalone web app on an Android 4 device.

Expected result:
The pwa should open.

Actual result:
Nightly and the web app crash every time you try to open an installed web app.
Crash report: https://crash-stats.mozilla.com/report/index/4c724be7-c2c1-4878-82cf-3e3512170405

Notes:
Reproduces 100% on Android 4. I didn't get the same crash ID on other devices, but still got crashes like Bug 1351169 & Bug 1325021.

Comment 1

[Jan Henning [:JanH]]

TaskDescription API is 21+ only.

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Only setTaskDescription on supported android

Comment 3

[Jan Henning [:JanH]]

Comment on attachment 8855475 [details] [diff] [review]
Only setTaskDescription on supported android

Review of attachment 8855475 [details] [diff] [review]:
-----------------------------------------------------------------

Seems fine, although since loadManifest now doesn't do anything useful on preLollipop at all (updateStatusBarColor is guarded by an API version check as well), maybe for older device we should skip file parsing completely for now? If you go down that route, just add a comment above ActivityManager.TaskDescription taskDescription mentioning that this is API 21+ only (although I wonder why Android Studio didn't automatically pick up on this?).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2c72b26390de
Only setTaskDescription on supported android. r=janh

Comment 5

[Dale Harvey (:daleharvey)]

Thanks good catch, I changed it to early return and added the comment

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2c72b26390de

Comment 7

[Oana Horvath [:ohorvath]]

Verified as fixed on Nightly 55.0a1 (2017-04-10). Web apps can be installed on Android 4 devices.
Devices: 
- Lenovo A536 (Android 4.4.2);