1353735 - Fix errors in webrender_bindings

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

Found a couple of minor things while working on the binding generator.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1353735 - Fix missing ABI declaration.

Review commit: https://reviewboard.mozilla.org/r/126816/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126816/

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1353735 - Fix return value of binding function.

Review commit: https://reviewboard.mozilla.org/r/126818/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126818/

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8854865 [details]
Bug 1353735 - Fix missing ABI declaration.

https://reviewboard.mozilla.org/r/126816/#review129506

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8854866 [details]
Bug 1353735 - Fix return value of binding function.

https://reviewboard.mozilla.org/r/126818/#review129508

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1353735 - Fix repr(C) on enums to repr(u32).

Review commit: https://reviewboard.mozilla.org/r/126842/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126842/

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8854865 [details]
Bug 1353735 - Fix missing ABI declaration.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/126816/diff/1-2/

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8854866 [details]
Bug 1353735 - Fix return value of binding function.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/126818/diff/1-2/

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8854905 [details]
Bug 1353735 - Fix repr(C) on enums to repr(u32).

https://reviewboard.mozilla.org/r/126842/#review129510

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/9828d1bc6f8c
Fix missing ABI declaration. r=jrmuizel
https://hg.mozilla.org/projects/graphics/rev/f27f0fc7509f
Fix return value of binding function. r=jrmuizel
https://hg.mozilla.org/projects/graphics/rev/5d186adb6272
Fix repr(C) on enums to repr(u32). r=jrmuizel

Comment 10

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/9828d1bc6f8c
https://hg.mozilla.org/mozilla-central/rev/f27f0fc7509f
https://hg.mozilla.org/mozilla-central/rev/5d186adb6272