1353789 - unship deployment-checker

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler]]

The deployment-checker has done its work for now - we need to un-ship it.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Attachment: bug 1353789 - unship deployment-checker

Review commit: https://reviewboard.mozilla.org/r/126880/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126880/

Comment 2

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 8854962 [details]
bug 1353789 - unship deployment-checker

https://reviewboard.mozilla.org/r/126880/#review129556

This is the reciprocal of https://reviewboard.mozilla.org/r/118786/diff/2#index_header , so LGTM.

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8854962 [details]
bug 1353789 - unship deployment-checker

https://reviewboard.mozilla.org/r/126880/#review129558

Comment 4

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0eec53b46cec
unship deployment-checker r=Felipe,jcj

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0eec53b46cec

Comment 7

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8854962 [details]
bug 1353789 - unship deployment-checker

(Since we stopped offering this via go-faster/balrog, I'm not actually sure if uplifting this to release is relevant, but just in case it is...)

Approval Request Comment
[Feature/Bug causing the regression]: bug 1346017
[User impact if declined]: increased traffic on some Mozilla sites
[Is this code covered by automated tests?]: n/a
[Has the fix been verified in Nightly?]: n/a
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: this just removes a standalone system add-on (upon which nothing else depends)
[String changes made/needed]: none

Comment 8

[:Felipe Gomes (needinfo for replies!)]

(In reply to David Keeler [:keeler] (use needinfo?) from comment #7)
> Comment on attachment 8854962 [details]
> bug 1353789 - unship deployment-checker
> 
> (Since we stopped offering this via go-faster/balrog, I'm not actually sure
> if uplifting this to release is relevant, but just in case it is...)

Yeah it is. Otherwise it will get picked up again on the next version update, specially now that bug 1350064 has been fixed (and uplifted).

Comment 9

[Dana Keeler (she/her) (use needinfo) [:keeler]]

(In reply to :Felipe Gomes (needinfo me!) from comment #8)
> (In reply to David Keeler [:keeler] (use needinfo?) from comment #7)
> > Comment on attachment 8854962 [details]
> > bug 1353789 - unship deployment-checker
> > 
> > (Since we stopped offering this via go-faster/balrog, I'm not actually sure
> > if uplifting this to release is relevant, but just in case it is...)
> 
> Yeah it is. Otherwise it will get picked up again on the next version
> update, specially now that bug 1350064 has been fixed (and uplifted).

On the 52 -> 53 update? Or is this in anticipation of another dot release of 52? (which as I understand is not planned)

Comment 10

[:Felipe Gomes (needinfo for replies!)]

On both. But I don't know of any dot release planned either, so I was thinking of 52 -> 53

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

I still don't understand if there is a point in uplifting this to the mozilla-release branch right now. 

As I understand it we just want to make sure it's not in-tree for 53 beta so that when it's merged to release we don't hit this problem again. Felipe is that correct?

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8854962 [details]
bug 1353789 - unship deployment-checker

Let's uplift this to aurora and beta for now so that it has a chance to make it into beta 10. (If not, it should still land on 53 beta before the merge and RC build)

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/81c66fadfbf5

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/65eb65fb5933

Comment 15

[:Felipe Gomes (needinfo for replies!)]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #11)
> I still don't understand if there is a point in uplifting this to the
> mozilla-release branch right now. 
> 
> As I understand it we just want to make sure it's not in-tree for 53 beta so
> that when it's merged to release we don't hit this problem again. Felipe is
> that correct?

Yeah, that is correct. Or, to be fair, that's the main concern. It would be probably good to have this included if a new dot release is made, but if there's not one on the radar right now I don't know if it's worth bothering.

Comment 16

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8854962 [details]
bug 1353789 - unship deployment-checker

53 is now on mozilla-release, and this is fixed in 53, so I'm clearing the release approval flag.