Closed Bug 1353789 Opened 3 years ago Closed 3 years ago

unship deployment-checker

Categories

(Core :: Security: PSM, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox53 --- fixed
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: keeler, Assigned: keeler)

Details

Attachments

(1 file)

The deployment-checker has done its work for now - we need to un-ship it.
Comment on attachment 8854962 [details]
bug 1353789 - unship deployment-checker

https://reviewboard.mozilla.org/r/126880/#review129556

This is the reciprocal of https://reviewboard.mozilla.org/r/118786/diff/2#index_header , so LGTM.
Attachment #8854962 - Flags: review?(jjones) → review+
Comment on attachment 8854962 [details]
bug 1353789 - unship deployment-checker

https://reviewboard.mozilla.org/r/126880/#review129558
Attachment #8854962 - Flags: review?(felipc) → review+
Pushed by dkeeler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0eec53b46cec
unship deployment-checker r=Felipe,jcj
https://hg.mozilla.org/mozilla-central/rev/0eec53b46cec
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment on attachment 8854962 [details]
bug 1353789 - unship deployment-checker

(Since we stopped offering this via go-faster/balrog, I'm not actually sure if uplifting this to release is relevant, but just in case it is...)

Approval Request Comment
[Feature/Bug causing the regression]: bug 1346017
[User impact if declined]: increased traffic on some Mozilla sites
[Is this code covered by automated tests?]: n/a
[Has the fix been verified in Nightly?]: n/a
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: this just removes a standalone system add-on (upon which nothing else depends)
[String changes made/needed]: none
Attachment #8854962 - Flags: approval-mozilla-release?
Attachment #8854962 - Flags: approval-mozilla-beta?
Attachment #8854962 - Flags: approval-mozilla-aurora?
(In reply to David Keeler [:keeler] (use needinfo?) from comment #7)
> Comment on attachment 8854962 [details]
> bug 1353789 - unship deployment-checker
> 
> (Since we stopped offering this via go-faster/balrog, I'm not actually sure
> if uplifting this to release is relevant, but just in case it is...)

Yeah it is. Otherwise it will get picked up again on the next version update, specially now that bug 1350064 has been fixed (and uplifted).
(In reply to :Felipe Gomes (needinfo me!) from comment #8)
> (In reply to David Keeler [:keeler] (use needinfo?) from comment #7)
> > Comment on attachment 8854962 [details]
> > bug 1353789 - unship deployment-checker
> > 
> > (Since we stopped offering this via go-faster/balrog, I'm not actually sure
> > if uplifting this to release is relevant, but just in case it is...)
> 
> Yeah it is. Otherwise it will get picked up again on the next version
> update, specially now that bug 1350064 has been fixed (and uplifted).

On the 52 -> 53 update? Or is this in anticipation of another dot release of 52? (which as I understand is not planned)
Flags: needinfo?(felipc)
On both. But I don't know of any dot release planned either, so I was thinking of 52 -> 53
Flags: needinfo?(felipc)
I still don't understand if there is a point in uplifting this to the mozilla-release branch right now. 

As I understand it we just want to make sure it's not in-tree for 53 beta so that when it's merged to release we don't hit this problem again. Felipe is that correct?
Comment on attachment 8854962 [details]
bug 1353789 - unship deployment-checker

Let's uplift this to aurora and beta for now so that it has a chance to make it into beta 10. (If not, it should still land on 53 beta before the merge and RC build)
Attachment #8854962 - Flags: approval-mozilla-beta?
Attachment #8854962 - Flags: approval-mozilla-beta+
Attachment #8854962 - Flags: approval-mozilla-aurora?
Attachment #8854962 - Flags: approval-mozilla-aurora+
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #11)
> I still don't understand if there is a point in uplifting this to the
> mozilla-release branch right now. 
> 
> As I understand it we just want to make sure it's not in-tree for 53 beta so
> that when it's merged to release we don't hit this problem again. Felipe is
> that correct?

Yeah, that is correct. Or, to be fair, that's the main concern. It would be probably good to have this included if a new dot release is made, but if there's not one on the radar right now I don't know if it's worth bothering.
Comment on attachment 8854962 [details]
bug 1353789 - unship deployment-checker

53 is now on mozilla-release, and this is fixed in 53, so I'm clearing the release approval flag.
Attachment #8854962 - Flags: approval-mozilla-release? → approval-mozilla-release-
You need to log in before you can comment on or make changes to this bug.