Crash during creation of windowless browsers

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Headless
RESOLVED FIXED
a year ago
9 months ago

People

(Reporter: bdahl, Assigned: bdahl)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Looks like a windowless browser can still trigger some calls in to gtk look and feel. 
https://bugzilla.mozilla.org/show_bug.cgi?id=1338004#c29
Created attachment 8854981 [details] [diff] [review]
Use PuppetWidget with windowless browsers.

During the creation of windowless browsers in non-headless mode there can
still be calls into GTK which isn't initialized with the HeadlessWidget. For now
we can just go back to using the PuppetWidget unless we're in headless mode.
Attachment #8854981 - Flags: review?(jmuizelaar)
Attachment #8854981 - Flags: review?(jmuizelaar) → review+
Keywords: checkin-needed
Assignee: nobody → bdahl

Comment 2

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a74c2af36aa4
Use PuppetWidget with windowless browsers. r=jrmuizel
Keywords: checkin-needed

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a74c2af36aa4
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Component: General → Headless

Comment 5

9 months ago
[bugday-20170802] Started firefox 55.0 with --headless flag and it crashes with the following output:
> *** You are running in headless mode.
> (firefox:27959): Gdk-CRITICAL **: gdk_x11_display_get_xdisplay: assertion 'GDK_IS_DISPLAY (display)' failed
> ExceptionHandler::GenerateDump cloned child 28004
> ExceptionHandler::SendContinueSignalToChild sent continue signal to child
> ExceptionHandler::WaitForContinueSignal waiting for continue signal...
> exit 11

With firefox already running, I get this instead:

> *** You are running in headless mode.
> Firefox is already running, but is not responding. To open a new window, you must first close the existing Firefox process, or restart your system.
@Jagan: Thanks for the report!  Your crash looks different from this one, per the description in this bug and the stack in bug 1338004, comment 29.  Can you file a new bug report describing your crash?

Comment 7

9 months ago
I have filed one here bug 1386727.
You need to log in before you can comment on or make changes to this bug.