1353814 - Crash during creation of windowless browsers

Status: RESOLVED FIXED

(Firefox :: Headless, defect)

Description

[Brendan Dahl [:bdahl]]

Looks like a windowless browser can still trigger some calls in to gtk look and feel. 
https://bugzilla.mozilla.org/show_bug.cgi?id=1338004#c29

Comment 1

[Brendan Dahl [:bdahl]]

Attachment: Use PuppetWidget with windowless browsers.

During the creation of windowless browsers in non-headless mode there can
still be calls into GTK which isn't initialized with the HeadlessWidget. For now
we can just go back to using the PuppetWidget unless we're in headless mode.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a74c2af36aa4
Use PuppetWidget with windowless browsers. r=jrmuizel

Comment 3

[Kris Maglione [:kmag]]

Thanks!

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a74c2af36aa4

Comment 5

[Jagan]

[bugday-20170802] Started firefox 55.0 with --headless flag and it crashes with the following output:
> *** You are running in headless mode.
> (firefox:27959): Gdk-CRITICAL **: gdk_x11_display_get_xdisplay: assertion 'GDK_IS_DISPLAY (display)' failed
> ExceptionHandler::GenerateDump cloned child 28004
> ExceptionHandler::SendContinueSignalToChild sent continue signal to child
> ExceptionHandler::WaitForContinueSignal waiting for continue signal...
> exit 11

With firefox already running, I get this instead:

> *** You are running in headless mode.
> Firefox is already running, but is not responding. To open a new window, you must first close the existing Firefox process, or restart your system.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

@Jagan: Thanks for the report!  Your crash looks different from this one, per the description in this bug and the stack in bug 1338004, comment 29.  Can you file a new bug report describing your crash?

Comment 7

[Jagan]

I have filed one here bug 1386727.