1353831 - OneOff block in search bar doesn't update text if Customize was opened at least once

Status: VERIFIED FIXED

(Firefox :: Search, defect, P1)

Description

[684sigma]

I have a problem with Firefox Beta 53. It also happens in Beta 52, Nightly 55. Doesn't happen in ESR 45
After changing anything in customize, one of text labels in search bar stops updating, and it's distracting.
Here's how to reproduce it:

1. Launch Firefox, type "ab" in search bar, wait until suggestions show up, type "c".
2. Open customize, move some button from the "Additional tools and features" to menu. Close customize
3. Type "xyz" in search bar

Result: OneOff block in suggestions displays "Search for abc with:"
Expected: It should display "Search for xyz with:"

Comment 1

[YF (Yang)]

Regression range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8a98cde343c2eee3ede571646cabf5178816530d&tochange=2e12de6eac1024c2f0520df206295ae89412bd7c

474f38fc48be	Drew Willcoxon — Bug 1180944 - Implement one-off searches from Awesomebar. r=mak,florian

Comment 2

[684sigma]

Updated regression range (generated by mozregression-gui 0.9.6):
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=4e8b0579b51108c1d7c60bd1d70053136ec4521d&tochange=474f38fc48be9f97b49b084ebf0b59293b81cf16

Mozregression-gui 0.9.7 can't even test repository "fx-team", filed Bug 1354451.

Comment 3

[William Lachance (:wlach)]

Hi Drew, could you look into this? Seems like this is most likely fallout from your patch.

Comment 4

[Drew Willcoxon :adw]

Attachment: Bug 1353831 - OneOff block in search bar doesn't update text if Customize was opened at least once.

Review commit: https://reviewboard.mozilla.org/r/128890/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128890/

Comment 5

[Drew Willcoxon :adw]

The problem is that the one-off's `textbox` property is reset and not set again after exiting customize mode.  The urlbar sets that property (and `popup`) in its constructor and doesn't have the problem.  That's what this patch does for the searchbar.

Comment 6

[Florian Quèze [:florian]]

Comment on attachment 8856980 [details]
Bug 1353831 - OneOff block in search bar doesn't update text if Customize was opened at least once.

https://reviewboard.mozilla.org/r/128890/#review132484

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late for 53, nice that we have a fix here though.

Comment 8

[Drew Willcoxon :adw]

Whoops, thought I landed this.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3742522c4533
OneOff block in search bar doesn't update text if Customize was opened at least once. r=florian

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76b21e5cbafe
Backed out changeset 3742522c4533 for failing at least test_focus_autocomplete.xul in a11y suite on OSX 10.10 debug. r=backout

Comment 11

[Drew Willcoxon :adw]

Comment on attachment 8856980 [details]
Bug 1353831 - OneOff block in search bar doesn't update text if Customize was opened at least once.

Clearing the review flag so that hopefully mozreview will let me push a new patch...

Comment 12

[Drew Willcoxon :adw]

Comment on attachment 8856980 [details]
Bug 1353831 - OneOff block in search bar doesn't update text if Customize was opened at least once.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/128890/diff/1-2/

Comment 13

[Drew Willcoxon :adw]

Comment on attachment 8856980 [details]
Bug 1353831 - OneOff block in search bar doesn't update text if Customize was opened at least once.

Uh... setting the r+ again.

Comment 14

[Drew Willcoxon :adw]

Some accessibility tests create their own <searchbar> that doesn't use the normal searchbar popup, so they failed when the searchbar constructor ran and assumed that this.textbox.popup.oneOffButtons was defined.

I'll push this to try and then land again.

Comment 15

[Drew Willcoxon :adw]

Try looks OK.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26a0e8b9f278
OneOff block in search bar doesn't update text if Customize was opened at least once. r=florian

Comment 17

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/26a0e8b9f278

Comment 18

[Ryan VanderMeulen [:RyanVM]]

This feels pretty edge-casey to me. Should we consider this for 54 uplift or let it ride the 55 train?

Comment 19

[Drew Willcoxon :adw]

We should uplift it.

Comment 20

[Drew Willcoxon :adw]

Attachment: Aurora 54 patch

Approval Request Comment
[Feature/Bug causing the regression]: One-off searches in the awesomebar, bug 1180944
[User impact if declined]: This bug
[Is this code covered by automated tests?]: This code is, but not this specific bug
[Has the fix been verified in Nightly?]: Not officially
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Small change, tested manually, feature is well covered by tests
[String changes made/needed]: None

Comment 21

[Gerry Chang [:gchang]]

Comment on attachment 8858911 [details] [diff] [review]
Aurora 54 patch

Fix a regression. Aurora54+.

Comment 22

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0c74a611a3ec

Comment 23

[Simona Badau, Desktop QA]

Reproduced the initial issue using Nightly 55.0a1 (Build ID: 20170412030252) on Windows 10 x64.

Verified as fixed using the latest Nightly 55.0a1 (Build ID: 20170418030220) on Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.12

Comment 24

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed using Firefox 54 beta 1 under Win 10 64-bit, Ubuntu 14.04 64-bit and Mac OS X 10.11.