1354006 - [selectors4] Remove "interact" flag from :focus-within tests

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Manuel Rego Casasnovas]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.133 Safari/537.36

Steps to reproduce:


This comes from a PR in WPT repo:
https://github.com/w3c/web-platform-tests/pull/5370

The issue is that some reference tests are marked with "interact" flag,
which causes them to be considered manual tests instead of automatic.
However they are actually run automatically with some JavaScript.

As we're cannot modify the tests in WPT repo under css/vendor-imports/,
this should be done directly on Firefox source code.

Comment 1

[Manuel Rego Casasnovas]

Attachment: [selectors4] Remove "interact" flag from :focus-within tests

This patch has been extracted from:
https://github.com/w3c/web-platform-tests/pull/5370

The problem is that the "interact" flag on these tests
causes that they are considered manual,
when they can be run automatically.

This patch removes the "interact" flag and uses "reftest-wait" class
to be sure that the test has been completed.

Comment 2

[Manuel Rego Casasnovas]

The tests were originally introduced in bug #1176997.

This is my first attempt to upload a patch here, so please forgive me if I did something wrong. :-)

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8855199 [details] [diff] [review]
[selectors4] Remove "interact" flag from :focus-within tests

r?xidorn since he reviewed the layout parts in bug 1176997

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8855199 [details] [diff] [review]
[selectors4] Remove "interact" flag from :focus-within tests

Review of attachment 8855199 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/83eeccc86bab
[selectors4] Remove "interact" flag from :focus-within tests. r=xidorn

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/83eeccc86bab