Avoid loading unneeded Telemetry JS modules in content process

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
Telemetry
P3
normal
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: gfritzsche, Assigned: mccr8, Mentored)

Tracking

(Blocks: 1 bug)

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [measurement:client] [lang=js] [good next bug])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

10 months ago
Per bug 1350472 we load Telemetry modules in the content process that are not actually needed:
- TelemetrySend.jsm
- ClientID.jsm

After any changes we should:
- build: mach build
- check eslint: mach eslint toolkit/components/telemetry
- run tests: mach test toolkit/components/telemetry/tests/unit
(Assignee)

Updated

10 months ago
Blocks: 1350472
(Assignee)

Updated

10 months ago
Assignee: nobody → continuation
(Assignee)

Comment 1

10 months ago
It looks like this would also avoid loading PromiseUtils.jsm and ServiceRequest.jsm at startup in content processes.
Comment hidden (mozreview-request)
(Reporter)

Comment 3

10 months ago
mozreview-review
Comment on attachment 8857163 [details]
Bug 1354041 - Lazily load TelemetrySend in TelemetrySession.

https://reviewboard.mozilla.org/r/129104/#review131826
Attachment #8857163 - Flags: review?(gfritzsche) → review+
(Reporter)

Comment 4

10 months ago
Do we still load ClientID.jsm after this?
We should not need that module at all in content processes.
I'd be happy to take that to a separate bug though.
(Assignee)

Comment 5

10 months ago
(In reply to Georg Fritzsche [:gfritzsche] from comment #4)
> Do we still load ClientID.jsm after this?

We do not. Not loading TelemetrySend is sufficient to avoid loading it.

Comment 6

10 months ago
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/86a7adbdc6ef
Lazily load TelemetrySend in TelemetrySession. r=gfritzsche

Comment 7

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/86a7adbdc6ef
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.