|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
Per bug 1350472 we load Telemetry modules in the content process that are not actually needed: - TelemetrySend.jsm - ClientID.jsm After any changes we should: - build: mach build - check eslint: mach eslint toolkit/components/telemetry - run tests: mach test toolkit/components/telemetry/tests/unit
It looks like this would also avoid loading PromiseUtils.jsm and ServiceRequest.jsm at startup in content processes.
Comment on attachment 8857163 [details] Bug 1354041 - Lazily load TelemetrySend in TelemetrySession. https://reviewboard.mozilla.org/r/129104/#review131826
Attachment #8857163 - Flags: review?(gfritzsche) → review+
Do we still load ClientID.jsm after this? We should not need that module at all in content processes. I'd be happy to take that to a separate bug though.
(In reply to Georg Fritzsche [:gfritzsche] from comment #4) > Do we still load ClientID.jsm after this? We do not. Not loading TelemetrySend is sufficient to avoid loading it.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/86a7adbdc6ef Lazily load TelemetrySend in TelemetrySession. r=gfritzsche
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.