1354068 - Uninitialized rv in nsWebShellWindow.cpp

Status: RESOLVED FIXED

(Firefox :: Headless, enhancement)

Description

[Randell Jesup [:jesup] (needinfo me)]

From Coverity:

________________________________________________________________________________________________________
*** CID 1404859:  Uninitialized variables  (UNINIT)
/xpfe/appshell/nsWebShellWindow.cpp: 161 in nsWebShellWindow::Initialize(nsIXULWindow *, nsIXULWindow *, nsIURI *, int, int, bool, nsITabParent *, mozIDOMWindowProxy *, nsWidgetInitData &)()
155         if (mWindow) {
156           rv = NS_OK;
157         }
158       } else {
159         mWindow = do_CreateInstance(kWindowCID, &rv);
160       }
>>>     CID 1404859:  Uninitialized variables  (UNINIT)
>>>     Using uninitialized value "rv".
161       if (NS_OK != rv) {
162         return rv;
163       }
164     
165       /* This next bit is troublesome. We carry two different versions of a pointer
166          to our parent window. One is the parent window's widget, which is passed

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: fix uninitialized rv in some paths in nsWebShellWindow

MozReview-Commit-ID: LyQUAvVXlr2

Comment 2

[Brendan Dahl [:bdahl]]

Comment on attachment 8855277 [details] [diff] [review]
fix uninitialized rv in some paths in nsWebShellWindow

Review of attachment 8855277 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c858836be29e
fix uninitialized rv in some paths in nsWebShellWindow r=bdahl

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c858836be29e