Closed Bug 1354068 Opened 4 years ago Closed 4 years ago

Uninitialized rv in nsWebShellWindow.cpp

Categories

(Firefox :: Headless, enhancement)

Product:
Firefox
Component:
Headless
Version:
35 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: jesup, Assigned: jesup)

References

Details

Attachments

(1 file)

fix uninitialized rv in some paths in nsWebShellWindow
1.55 KB, patch
bdahl
: review+
Details | Diff | Splinter Review 
From Coverity:

________________________________________________________________________________________________________
*** CID 1404859:  Uninitialized variables  (UNINIT)
/xpfe/appshell/nsWebShellWindow.cpp: 161 in nsWebShellWindow::Initialize(nsIXULWindow *, nsIXULWindow *, nsIURI *, int, int, bool, nsITabParent *, mozIDOMWindowProxy *, nsWidgetInitData &)()
155         if (mWindow) {
156           rv = NS_OK;
157         }
158       } else {
159         mWindow = do_CreateInstance(kWindowCID, &rv);
160       }
>>>     CID 1404859:  Uninitialized variables  (UNINIT)
>>>     Using uninitialized value "rv".
161       if (NS_OK != rv) {
162         return rv;
163       }
164     
165       /* This next bit is troublesome. We carry two different versions of a pointer
166          to our parent window. One is the parent window's widget, which is passed
MozReview-Commit-ID: LyQUAvVXlr2
Attachment #8855277 - Flags: review?(bdahl)
Comment on attachment 8855277 [details] [diff] [review]
fix uninitialized rv in some paths in nsWebShellWindow

Review of attachment 8855277 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8855277 - Flags: review?(bdahl) → review+
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c858836be29e
fix uninitialized rv in some paths in nsWebShellWindow r=bdahl
https://hg.mozilla.org/mozilla-central/rev/c858836be29e
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Component: General → Headless
You need to log in before you can comment on or make changes to this bug.