Status
()
People
(Reporter: jesup, Assigned: jesup)
Tracking
(Blocks: 1 bug)
Firefox Tracking Flags
(firefox55 fixed)
Details
Attachments
(1 attachment)
|
1.55 KB,
patch
|
bdahl
:
review+
|
Details | Diff | Splinter Review |
From Coverity:
________________________________________________________________________________________________________
*** CID 1404859: Uninitialized variables (UNINIT)
/xpfe/appshell/nsWebShellWindow.cpp: 161 in nsWebShellWindow::Initialize(nsIXULWindow *, nsIXULWindow *, nsIURI *, int, int, bool, nsITabParent *, mozIDOMWindowProxy *, nsWidgetInitData &)()
155 if (mWindow) {
156 rv = NS_OK;
157 }
158 } else {
159 mWindow = do_CreateInstance(kWindowCID, &rv);
160 }
>>> CID 1404859: Uninitialized variables (UNINIT)
>>> Using uninitialized value "rv".
161 if (NS_OK != rv) {
162 return rv;
163 }
164
165 /* This next bit is troublesome. We carry two different versions of a pointer
166 to our parent window. One is the parent window's widget, which is passed
|
(Assignee) | |
Comment 1•a year ago
|
||
Created attachment 8855277 [details] [diff] [review] fix uninitialized rv in some paths in nsWebShellWindow MozReview-Commit-ID: LyQUAvVXlr2
Attachment #8855277 -
Flags: review?(bdahl)
|
||
Comment 2•a year ago
|
||
Comment on attachment 8855277 [details] [diff] [review] fix uninitialized rv in some paths in nsWebShellWindow Review of attachment 8855277 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8855277 -
Flags: review?(bdahl) → review+
Pushed by rjesup@wgate.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c858836be29e fix uninitialized rv in some paths in nsWebShellWindow r=bdahl
|
||
Comment 4•a year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c858836be29e
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
|
||
Updated•11 months ago
|
||
Component: General → Headless
You need to log in
before you can comment on or make changes to this bug.
Description
•