Closed Bug 1354113 Opened 3 years ago Closed 3 years ago

Add 'Show Library', 'Extensions', 'Preferences' and 'Customize Toolbar' buttons to static hamburger menu

Categories

(Firefox :: Toolbars and Customization, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 55
Iteration:
55.5 - May 15
Tracking Status
firefox55 --- verified

People

(Reporter: mikedeboer, Assigned: Gijs)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [photon-structure])

Attachments

(1 file)

The icon will be smaller; the size to be the same as all other menu item icons. In order of appearance:

* The 'Show Library' button is a new widget that will show the library window, just like 'Show All Bookmarks' and 'Show All History' do. Its icon will be of the new Library menu button.
* The 'Extensions' button is a re-labeled version of the 'Add-ons' button in the current menu panel. Icon and command stay the same.
* The 'Preferences' menu is the same as the one from the current menu panel.
* The 'Customize Toolbar' is a re-labeled version of the 'Customize' button in the current menu panel. Icon and command stay the same.

Please take a possible future hotkey assignment into account. (no pun intended.)

A separator is shown below the 'Customize Toolbar' menu item.
Blocks: 1354116
No longer blocks: 1354116
No longer depends on: 1354108
Flags: qe-verify+
Priority: -- → P2
QA Contact: gwimberly
Whiteboard: [photon] → [photon-structure]
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 55.5 - May 15
Priority: P2 → P1
Comment on attachment 8865905 [details]
Bug 1354113 - add library,add-ons,preferences,customize items,

https://reviewboard.mozilla.org/r/137494/#review140676

r=me with the following two issues fixed.

::: browser/components/customizableui/content/panelUI.js:302
(Diff revision 1)
> +        if (gPhotonStructure) {
> +          CustomizableUI.addPanelCloseListeners(this.panel);
> +        }

The listeners are added in "popupshowING" but are removed in "popuphiddeN". "popupshowing" will run before the popup is visible, so we should limit the amount of code run before it is visible. Can you move this code to "popupshown" ?

::: browser/themes/shared/menu-icons/customize.svg:4
(Diff revision 1)
> +<!-- This Source Code Form is subject to the terms of the Mozilla Public
> +   - License, v. 2.0. If a copy of the MPL was not distributed with this
> +   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
> +<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16">

The other SVG files have fill="context-fill" but customize.svg doesn't. Since the CSS has -moz-context-properties: fill; for the customize button, you should probably add it fill="context-fill" here.
Attachment #8865905 - Flags: review?(jaws) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2e782ecaa298
add library,add-ons,preferences,customize items, r=jaws
https://hg.mozilla.org/mozilla-central/rev/2e782ecaa298
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
I was able to verify this on Windows using the information from Comment 5 but there does not seem to be a Linux build available, and the Mac build leads to a list of builds here: https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-central-macosx64/

Can you give me some additional information on how to access the Mac/Linux builds so I can verify this fix? Thanks!
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to Grover Wimberly IV [:Grover-QA] from comment #6)
> I was able to verify this on Windows using the information from Comment 5
> but there does not seem to be a Linux build available, and the Mac build
> leads to a list of builds here:
> https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-central-
> macosx64/
> 
> Can you give me some additional information on how to access the Mac/Linux
> builds so I can verify this fix? Thanks!

I would wait until tomorrow when there's nightlies? :-)

Otherwise, try builds from https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=ce2218406119c36a551e3faea4e192186ee46cc5 ?
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(gwimberly)
Okay, will wait until tomorrow. Thanks!
Verified on Windows, Mac OSX, and Linux
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Flags: needinfo?(gwimberly)
Blocks: 1387512
You need to log in before you can comment on or make changes to this bug.