Mozilla LDAP Address Book integration in 3rd party products fails



17 years ago
15 years ago


(Reporter: john.marmion, Assigned: john.marmion)


Firefox Tracking Flags

(Not tracked)



(1 attachment, 1 obsolete attachment)



17 years ago integrates with the Mozilla Address Book using both the Mozilla
Personal Address Books and the Mozilla LDAP Address Books. A recent change to
Mozilla where the RDF data source is now based on the preference name of the
Address Book source as opposed to been earlier based on the URI scheme means
that fails when the LDAP Address Book is not a preference in
Mozilla. The reason for changing the RDF data source to be based on the
preference name is a very valid one. But in order for e.g. to
intregrate with the LDAP Address Book, it would now have to update the Mozilla
Preferences File. This should not be the role of a third-party product. Instead
Mozilla should support both.

Comment 1

17 years ago
Posted patch Small patch to achieve this (obsolete) — Splinter Review

Comment 2

17 years ago
requested a review for this patch yesterday.

r= wanted
Hardware: PC → All
The patch looks ok to me, assuming you get sspitzer to sr it and he's ok with it
too.  However, I'd like to see the comments changed to explain why that code
works so that someone who's not familiar with the history of the codebase can
easily see what's going on (ie explain what mURINoQuery is likely to contain). 
Reassigning to you, since you've got checkin priviledges now.  :-)
Assignee: racham → john.marmion

Comment 4

17 years ago
Thanks for the feedback Dan. I have attempted to explain this patch and put it
in context. Let me know if this is sufficient.
Attachment #77638 - Attachment is obsolete: true
Comment on attachment 79239 [details] [diff] [review]
Update Patch with an explaination for this.
Attachment #79239 - Flags: review+
Comment on attachment 79239 [details] [diff] [review]
Update Patch with an explaination for this.


for mozilla, CopyCharPref() should succeed, so the code path doesn't change.

thanks for adding the clear comment.

if only more of the ab was so clear.
Attachment #79239 - Flags: superreview+

Comment 7

17 years ago
fix checked in.


17 years ago
QA Contact: nbaca → yulian
John, you realize that if you need this on the 1.0 branch, there are other steps
to go through, right?

Comment 9

17 years ago
Thanks Dan, I have mailed the and requested this patch for
inclusion into the mozilla 1.0 branch. 

Comment 10

17 years ago
This fix is in the tree and the bug should have been marked resolved.
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 11

17 years ago
Yulian, as the reporter I can confirm that this bug is fixed if you need

Comment 12

17 years ago
20020910 Trunk build on WIn2K

Thank you, John!
LDAP related functionalites are working fine. Marked as Verified.
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.