ElementRestyler::ComputeStyleChangeFor dynamic profiler label might have too much overhead

RESOLVED FIXED in Firefox 55

Status

()

Core
Gecko Profiler
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

(Blocks: 1 bug)

Trunk
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 months ago
If the profiler is running, ComputeStyleChangeFor calls ToString() for the restyled element. This might be artificially inflating the restyle times we see in profiles.
It might be worth removing this instrumentation, until we have a way to only run it when specifically requested.

http://searchfox.org/mozilla-central/source/layout/base/GeckoRestyleManager.cpp#3061
Comment hidden (mozreview-request)
Comment on attachment 8855510 [details]
Bug 1354255 - Remove ElementRestyler::ComputeStyleChangeFor profiler instrumentation due to overhead.

https://reviewboard.mozilla.org/r/127356/#review130088

Thank you!
Attachment #8855510 - Flags: review?(ehsan) → review+

Comment 3

3 months ago
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/596704d5da99
Remove ElementRestyler::ComputeStyleChangeFor profiler instrumentation due to overhead. r=Ehsan
Blocks: 1345440

Comment 4

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/596704d5da99
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55

Comment 5

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/596704d5da99
Assignee: nobody → mstange
You need to log in before you can comment on or make changes to this bug.