Closed Bug 1354255 Opened 3 years ago Closed 3 years ago

ElementRestyler::ComputeStyleChangeFor dynamic profiler label might have too much overhead

Categories

(Core :: Gecko Profiler, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

If the profiler is running, ComputeStyleChangeFor calls ToString() for the restyled element. This might be artificially inflating the restyle times we see in profiles.
It might be worth removing this instrumentation, until we have a way to only run it when specifically requested.

http://searchfox.org/mozilla-central/source/layout/base/GeckoRestyleManager.cpp#3061
Comment on attachment 8855510 [details]
Bug 1354255 - Remove ElementRestyler::ComputeStyleChangeFor profiler instrumentation due to overhead.

https://reviewboard.mozilla.org/r/127356/#review130088

Thank you!
Attachment #8855510 - Flags: review?(ehsan) → review+
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/596704d5da99
Remove ElementRestyler::ComputeStyleChangeFor profiler instrumentation due to overhead. r=Ehsan
Blocks: 1345440
https://hg.mozilla.org/mozilla-central/rev/596704d5da99
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Assignee: nobody → mstange
You need to log in before you can comment on or make changes to this bug.