1354278 - The blue fill in the downloads button flickers

Status: NEW

(Core :: Graphics, defect, P3)

Description

[Markus Stange [:mstange]]

Attachment: screen recording

See the attached screen recording. This looks really bad.

Comment 1

[pass2pawan]

How could i go about fixing this ? can someone mentor me on this

Comment 2

[Markus Stange [:mstange]]

[Tracking Requested - why for this release]: Annoying regression

Comment 3

[:Paolo Amadini]

(In reply to pass2pawan from comment #1)
> How could i go about fixing this ? can someone mentor me on this

We don't know what's causing this bug, so we don't know how it could be fixed, and if it's a good bug to be mentored.

This will first need a look from the developer who implemented the feature, and it may require low-level graphics investigations.

Rex, have you seen this issue already? Is there something obvious, like the DOM changes, that may be causing this? If not, it may be a graphics bug.

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

No, I don't have any idea for now.
Only style.animationDelay of the element should be changed per our implementation. And that shouldn't produce flickering.
Unless someone sets percentage or visibility back and forth, but I didn't see that on my inspector.

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

And this is my first time seeing this issue. It didn't take place on machines I've tested.

In bug 1338984 the way of using css changed from modifying css.height directly to css animation - with a relatively rare usage. Comparing before and after bug 1338984 lands may clarify if that rare usage causes a low-level graphics issue. But first we need to know the exact condition to reproduce it.

Comment 6

[Julien Cristau [:jcristau]]

tracking as regression in 54.

Markus, does before/after bug 1338984 show a difference for you?

Comment 7

[Markus Stange [:mstange]]

It seems a bit better, but I can still get it to flicker. But I have to move my mouse over the toolbar and over tabs in order to trigger it. So the underlying issue is still there.

Comment 8

[Milan Sreckovic [:milan] (needinfo for best results)]

I believe Markus is on OS X.  How is this related (if at all) to bug 1359062?

Comment 9

[KM Lee [:rexboy] (inactivate after Sep. 22)]

I don't think they are related since the change on bug 1359062 will be no more than adjusting the constant for contrast from 125% to 170%. Implementation details will not be changed.

Comment 10

[Peter Chang[:pchang]]

I can't reproduce this issue on OS X by downloading a large file.

Comment 11

[Astley Chen (inactive)]

Markus, do you have any STR for this symptom?

Comment 12

[Markus Stange [:mstange]]

It's quite hard to reproduce now. It doesn't flash anymore on its own, only when I move my mouse over toolbarbuttons (and possibly trigger style flushes?).

I can reproduce it by going to https://www.virtualbox.org/wiki/Downloads , clicking the "OS X hosts" link, saving the file, and then quickly moving the mouse back and forth horizontally over the toolbar buttons between the search bar and the right edge of the window.

Comment 13

[Astley Chen (inactive)]

(In reply to Markus Stange [:mstange] from comment #12)
> I can reproduce it by going to https://www.virtualbox.org/wiki/Downloads ,
> clicking the "OS X hosts" link, saving the file, and then quickly moving the
> mouse back and forth horizontally over the toolbar buttons between the
> search bar and the right edge of the window.

Thanks for the STR above, though I still can't reproduce on my macOS Nightly55 build.
As the symptom is mitigated and not that easy to reproduce, let's keep an eye on it.

Comment 14

[Nathan Froyd [:froydnj]]

No clear STR, no assignee, wontfix for 54.

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

We could take a patch for this but I'm going to drop tracking since this sounds like an intermittent, minor polish issue.