1354323 - sendKeysToDialog should accept a string text field

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

https://bugzilla.mozilla.org/show_bug.cgi?id=1348782 changed the Marionette sendKeysToElement command to take the `text' instead of `value' field, and also changed the type from an array of strings to a string.

It consequently also made a change to event.sendKeysToElement to take a string rather than an array of strings, causing clients sending either `text' or `value' as an array of strings to the sendKeysToDialog command to error with the following stacktrace:

> Full message: TypeError: keyString.charAt is not a function
> Full stack: event.sendKeysToElement@chrome://marionette/content/event.js:1386:15
> GeckoDriver.prototype.sendKeysToDialog@chrome://marionette/content/driver.js:2667:3
> execute/req<@chrome://marionette/content/server.js:510:22
> TaskImpl_run@resource://gre/modules/Task.jsm:319:42
> TaskImpl@resource://gre/modules/Task.jsm:277:3
> asyncFunction@resource://gre/modules/Task.jsm:252:14
> Task_spawn@resource://gre/modules/Task.jsm:166:12
> execute@chrome://marionette/content/server.js:500:15
> onPacket@chrome://marionette/content/server.js:471:7
_onJSONObjectReady/<@chrome://marionette/content/server.js -> resource://devtools/shared/transport/transport.js:483:11
> exports.makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> > resource://devtools/shared/ThreadSafeDevToolsUtils.js:101:14
> exports.makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> > resource://devtools/shared/ThreadSafeDevToolsUtils.js:101:14

This was reported in https://github.com/mozilla/geckodriver/issues/607.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1354323 - Accept string text for sendKeysToDialog command;

As a follow-up to https://bugzilla.mozilla.org/show_bug.cgi?id=1354323,
this makes the Marionette sendKeysToDialog command take a text field
with a string, instead of the value field with an array of strings.

The relevant WebDriver specification change is
https://github.com/w3c/webdriver/pull/889.

Fixes: https://github.com/mozilla/geckodriver/issues/607

Review commit: https://reviewboard.mozilla.org/r/127404/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/127404/

Comment 2

[David Burns :automatedtester]

Comment on attachment 8855556 [details]
Bug 1354323 - Accept string text for sendKeysToDialog command;

https://reviewboard.mozilla.org/r/127404/#review130350

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e8560b43468
Accept string text for sendKeysToDialog command; r=automatedtester

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2e8560b43468

Comment 5

[Andreas Tolfsen ❲:ato❳]

Sheriffs: Please uplift to Aurora and Beta as test-only, because it is needed to bring parity to the API following https://bugzilla.mozilla.org/show_bug.cgi?id=1348782.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3d1083c028ac

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/55b6fa40ef64