sendKeysToDialog should accept a string text field

RESOLVED FIXED in Firefox 53

Status

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ato, Assigned: ato)

Tracking

(Blocks 1 bug)

Version 3
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed, firefox54 fixed, firefox55 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
https://bugzilla.mozilla.org/show_bug.cgi?id=1348782 changed the Marionette sendKeysToElement command to take the `text' instead of `value' field, and also changed the type from an array of strings to a string.

It consequently also made a change to event.sendKeysToElement to take a string rather than an array of strings, causing clients sending either `text' or `value' as an array of strings to the sendKeysToDialog command to error with the following stacktrace:

> Full message: TypeError: keyString.charAt is not a function
> Full stack: event.sendKeysToElement@chrome://marionette/content/event.js:1386:15
> GeckoDriver.prototype.sendKeysToDialog@chrome://marionette/content/driver.js:2667:3
> execute/req<@chrome://marionette/content/server.js:510:22
> TaskImpl_run@resource://gre/modules/Task.jsm:319:42
> TaskImpl@resource://gre/modules/Task.jsm:277:3
> asyncFunction@resource://gre/modules/Task.jsm:252:14
> Task_spawn@resource://gre/modules/Task.jsm:166:12
> execute@chrome://marionette/content/server.js:500:15
> onPacket@chrome://marionette/content/server.js:471:7
_onJSONObjectReady/<@chrome://marionette/content/server.js -> resource://devtools/shared/transport/transport.js:483:11
> exports.makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> > resource://devtools/shared/ThreadSafeDevToolsUtils.js:101:14
> exports.makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> > resource://devtools/shared/ThreadSafeDevToolsUtils.js:101:14

This was reported in https://github.com/mozilla/geckodriver/issues/607.
Assignee

Updated

2 years ago
Assignee: nobody → ato
Blocks: webdriver
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8855556 [details]
Bug 1354323 - Accept string text for sendKeysToDialog command;

https://reviewboard.mozilla.org/r/127404/#review130350
Attachment #8855556 - Flags: review?(dburns) → review+

Comment 3

2 years ago
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e8560b43468
Accept string text for sendKeysToDialog command; r=automatedtester
https://hg.mozilla.org/mozilla-central/rev/2e8560b43468
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Assignee

Comment 5

2 years ago
Sheriffs: Please uplift to Aurora and Beta as test-only, because it is needed to bring parity to the API following https://bugzilla.mozilla.org/show_bug.cgi?id=1348782.
Whiteboard: [checkin-needed-aurora][checkin-needed-beta]

Comment 6

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/3d1083c028ac
Whiteboard: [checkin-needed-aurora][checkin-needed-beta] → [checkin-needed-beta]

Comment 7

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/55b6fa40ef64
Whiteboard: [checkin-needed-beta]
You need to log in before you can comment on or make changes to this bug.