Closed Bug 1354350 Opened 3 years ago Closed 2 years ago

libyuv builds with NVALGRIND under MOZ_VALGRIND builds

Categories

(Core :: WebRTC, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: erahm, Assigned: dminor)

Details

Attachments

(1 file)

Similar to bug 1354207 it looks like libyuv disables valgrind macros even when we're performing a valgrind build.

It's not clear to me what gyp build setting controls that though.
Maybe P1 after reading bug 1354207. Is this breaking any builds?
Rank: 16
Priority: -- → P1
Comment on attachment 8872745 [details] [diff] [review]
Update libyuv moz.build to set valgrind gyp vars

Review of attachment 8872745 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8872745 - Flags: review?(drno) → review+
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dced7b9bcc5b
libyuv should not build with NVALGRIND under MOZ_VALGRIND builds; r=drno
https://hg.mozilla.org/mozilla-central/rev/dced7b9bcc5b
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.