stylo: NS_IMPL_FFI_REFCOUNTING should assert main thread

RESOLVED FIXED in Firefox 55

Status

()

Core
CSS Parsing and Computation
P1
normal
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: Bobby Holley (parental leave - send mail for anything urgent), Assigned: Bobby Holley (parental leave - send mail for anything urgent))

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Since it isn't threadsafe. This is tripping up steve's analysis in bug 1294915.

I'll write a patch.
Created attachment 8855580 [details] [diff] [review]
Assert main thread in NS_IMPL_FFI_REFCOUNTING. v1

MozReview-Commit-ID: 4J7yuJ8Thn0
Attachment #8855580 - Flags: review?(xidorn+moz)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6210acb5937227c4711f8c19566b4d1f194f7cb2
Attachment #8855580 - Flags: review?(xidorn+moz) → review+

Comment 3

8 months ago
Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3894b9366883
Assert main thread in NS_IMPL_FFI_REFCOUNTING. r=xidorn

Comment 4

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3894b9366883
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55

Comment 5

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3894b9366883
You need to log in before you can comment on or make changes to this bug.