1354487 - stylo: StoredRestyleHint::propagate behaves incorrectly during animation only restyle

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P1)

Description

[Cameron McCormack (:heycam)]

Currently StoredRestyleHint::propagate checks whether there are any animation restyle hints, and if so, removes them and returns null, and preserves any non-animation hints for the normal restyle that will happen later.  But if we are in an animation-only restyle, and a particular element has no animation restyle hints, we will fall through to the normal restyle handling, which clears the current restyle hint, and returns the propagated hint for children.

We should not be touching the non-animation hints in an animation restyle.

Comment 1

[Bobby Holley (:bholley)]

This seems like it would cause incremental restyle bugs after animations. Over to Hiro.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1354487 - Preserve restyle hints other than animation hints in propagate() during animation-only restyle.

Review commit: https://reviewboard.mozilla.org/r/129682/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129682/

Comment 3

[Cameron McCormack (:heycam)]

Comment on attachment 8857735 [details]
Bug 1354487 - Preserve restyle hints other than animation hints in propagate() during animation-only restyle.

https://reviewboard.mozilla.org/r/129682/#review132312

::: servo/components/style/data.rs:199
(Diff revision 1)
>          // If we have RESTYLE_CSS_ANIMATIONS restyle hint, it means we are in
>          // the middle of an animation only restyle. In that case, we don't need
>          // to propagate any restyle hints, and we need to remove ourselves.

Please update this comment, since it's not whether we have RESTYLE_CSS_ANIMATIONS that we use to decide how to propagate.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

https://github.com/servo/servo/pull/16396

Comment 5

[Hiroyuki Ikezoe (:hiro)]

https://hg.mozilla.org/integration/autoland/rev/97ab8b234e2f