1354499 - Intermittent image/test/mochitest/test_discardAnimatedImage.html | called finish() multiple times

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Treeherder Bug Filer]

Filed by: cbook [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=89488421&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/LY_u39X4Q22XwLyiUl1_wA/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Timothy Nikkel (:tnikkel)]

The test needs a simple bool check to avoid calling finish more than once. I'll push a patch in the morning. If it becomes too frequent you can temporarily disable the test until then.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/17d681fd2b32
Fix test_discardAnimatedImage.html to not call finish multiple times.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/415cd9f87458
Don't record further successful results after finishing in test_discardAnimatedImage.html.

Comment 4

[Phil Ringnalda (:philor)]

Backed out both in https://hg.mozilla.org/integration/mozilla-inbound/rev/21062cd63dd7 since both the first alone and the first plus the second resulted in a 50% chance of one or more "got frame update - Result logged after SimpleTest.finish()".

Comment 5

[Timothy Nikkel (:tnikkel)]

Okay, I'll stop wasting the sheriffs time. try server of what should be a proper fix

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ddd796e90821490b6fbf93866534d210fd5e34c

Until I get the results of that I'm going to disable this test and repush bug 686905. Since the test is passing its just a bookkeeping issue of the test calling ok(true,...) after the test is over.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e464cda66cf6
Fix test_discardAnimatedImage.html to not call finish multiple times.
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc67e6aa71ea
Don't record further successful results after finishing in test_discardAnimatedImage.html.
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d01060abf16
Do a better job of not recording successful results after test finish in test_discardAnimatedImage.html.
https://hg.mozilla.org/integration/mozilla-inbound/rev/008043649fc8
Disable test_discardAnimatedImage.html temporarily.

Comment 7

[Timothy Nikkel (:tnikkel)]

Test should be good now, try run with a bunch of re-triggers

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ddd796e90821490b6fbf93866534d210fd5e34c

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e1e3401303c8
Enable test_discardAnimatedImage.html.

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e464cda66cf6
https://hg.mozilla.org/mozilla-central/rev/fc67e6aa71ea
https://hg.mozilla.org/mozilla-central/rev/8d01060abf16
https://hg.mozilla.org/mozilla-central/rev/008043649fc8

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e1e3401303c8