1354523 - Add firefox-ui tests for SessionStore cookie restoration

Status: NEW

(Firefox :: Session Restore, enhancement)

Description

[Tim Taubert [:ttaubert] (inactive)]

We should add tests for the stuff we touched in bug 912717 to ensure that we properly restore session cookies with a full session restore, and also handle deferred session restores correctly.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: wip.patch

Here are the tests I started. They don't really work yet but are probably a good starting point. I'll definitely not get to this in the next two weeks (PTO), but I might not actually get to it at all.

So, anyone, please feel free to pick this up :)

Comment 2

[James B]

If/when these tests get written, please update bug 1468220. The "stuff we touched" in the session-restore changes from April 2017 is causing sessions to fail to clear correctly when the browser exits will all tabs for a host closed.

As I suggested over there, it's a security-relevant problem, because many sites tell you "close this tab and quit your browser to be sure you've logged out" or similar. Before bug 912717 landed, that worked correctly, and now it does not.