1354564 - Only update commands once per tab switch

Status: RESOLVED FIXED

(Core :: XUL, enhancement)

Description

[Neil Deakin]

Attachment: Possible patch

When switching tabs and doing other tasks, commands can be updated several times due to focus shifting around.

However, we could instead queue up requests to update commands until the tab switch is finished, preventing unnecessary work.

On my machine this appeared to save about 1ms per tab switch although I only tested my hand.

Comment 1

[Neil Deakin]

Attachment: Reduce updates during tab switch

The included test shows that command updates are reduced from 4 to 1 during a tab switch.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8861909 [details] [diff] [review]
Reduce updates during tab switch

Review of attachment 8861909 [details] [diff] [review]:
-----------------------------------------------------------------

I like it! Thanks!

::: browser/base/content/test/tabs/browser_tabswitch_updatecommands.js
@@ +1,1 @@
> +add_task(function* () {

Can you please add "use strict" at the top, and a short header comment describing what the test is testing?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1cd959bc881b
add a queue-up mechanism to command dispatchers that lets updates be queued up so that duplicates can be removed. Use this for tab switching to reduce the number of extraneous command updates that occur, r=mconley

Comment 4

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/1cd959bc881b