Closed Bug 1354576 Opened 7 years ago Closed 7 years ago

Allow to build NSPR on Solaris again

Categories

(Firefox Build System :: General, defect)

52 Branch
defect
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: petr.sumbera, Assigned: petr.sumbera)

Details

Attachments

(1 file, 1 obsolete file)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170323105023

Steps to reproduce:

NSPR build support for Solaris needs to be added.
Attached patch Bug1354576.patch (obsolete) — Splinter Review
Attachment #8855833 - Flags: review?(ted)
Component: Untriaged → Build Config
Attachment #8855833 - Flags: review?(mh+mozilla)
Comment on attachment 8855833 [details] [diff] [review]
Bug1354576.patch

Review of attachment 8855833 [details] [diff] [review]:
-----------------------------------------------------------------

Leaving it to ted.
Attachment #8855833 - Flags: review?(mh+mozilla)
Attached patch Bug1354576.patchSplinter Review
Added support for 64bits atomics (os_SunOS_x86_64.s).
Attachment #8855833 - Attachment is obsolete: true
Attachment #8855833 - Flags: review?(ted)
Attachment #8872547 - Flags: review?(ted)
Attachment #8872547 - Flags: review?(ted) → review+
Keywords: checkin-needed
Assignee: nobody → petr.sumbera
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2240d6e36324
Allow to build NSPR on Solaris again. r=ted
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2240d6e36324
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 55 → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: