1354577 - use new service worker mime type restrictions

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, enhancement, P2)

Description

[Ben Kelly [:bkelly, not reviewing]]

Spec change:

https://github.com/w3c/ServiceWorker/pull/1106

WPT change:

https://github.com/w3c/web-platform-tests/pull/5376

This widens the definition of what valid javascript mime types are.  Also, it tests that importScripts() mime types are enforced, which is something we don't currently do.

Comment 1

[Perry Jiang [:perry] [no longer employee, use ni?]]

Attachment: Bug 1354577 - allow ServiceWorkerContainer.register() to accept all valid JavaScript MIME types

Comment 2

[Perry Jiang [:perry] [no longer employee, use ni?]]

Attachment: Bug 1354577 - WIP

Depends on D6210

Comment 3

[Perry Jiang [:perry] [no longer employee, use ni?]]

Attachment: Bug 1354577 - WIP mime types

Depends on D6211

Comment 4

[Perry Jiang [:perry] [no longer employee, use ni?]]

Attachment: Bug 1354577 - require ServiceWorkerContainer.register() to only accept JavaScript MIME types r?edenchuang

- Change "ServiceWorkerRegisterMimeTypeError" to "ServiceWorkerRegisterMimeTypeError2"
to account for more acceptable MIME types

Comment 5

[Perry Jiang [:perry] [no longer employee, use ni?]]

Attachment: Bug 1354577 - require ServiceWorkerGlobalScope.importScripts() to only accept JavaScript MIME types r?edenchuang

- Make ServiceWorkerGlobalScope.importScripts() throw a NetworkError when receiving a
bad (i.e. non-JavaScript) MIME type
- Correct registration-tests-mime-types.js to expect TypeError when registering
a service worker that calls importScripts() with a bad MIME type, per spec
- Add WPT import-scripts-mime-types.https.html to test importScripts success/failure,
depending on MIME type

Depends on D6416

Comment 6

[Perry Jiang [:perry] [no longer employee, use ni?]]

(moz-phab submit unsquashed the two commits after updating for rebase)

Comment 7

[Noemi Erli[:noemi_erli]]

Removing checkin-needed tag, part 2 also needs review

Comment 8

[Eden Chuang[:edenchuang]]

Clear the needinfo

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13765 for changes under testing/web-platform/tests

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Please re-open the relevant Phabricator requests so Lando can push this.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Nevermind, pulsebot was just down.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73b6c5885020
require ServiceWorkerContainer.register() to only accept JavaScript MIME types r=edenchuang

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82c8a3aae99c
require ServiceWorkerGlobalScope.importScripts() to only accept JavaScript MIME types r=edenchuang

Comment 15

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/73b6c5885020
https://hg.mozilla.org/mozilla-central/rev/82c8a3aae99c

Comment 16

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 17

[Chris Mills [:cmills]]

I've documented this:

Made sure this restriction is mentioned on both relevant ref pages:
https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerContainer/register
https://developer.mozilla.org/en-US/docs/Web/API/WorkerGlobalScope/importScripts

Added a note about it to the Fx65 rel notes:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/65#APIs

Let me know if you think this needs anything else. Thanks!

Comment 18

[Perry Jiang [:perry] [no longer employee, use ni?]]

Thanks!