Give Focus and Klar a scheme

RESOLVED FIXED

Status

Focus-iOS
General
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: st3fan, Assigned: st3fan)

Tracking

Other
iOS

Details

(Whiteboard: Focus32)

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Give Focus and Klar a URL scheme. We don't have to handle incoming URLs yet. This is mainly to let Firefox detect is Focus or Klar is installed. Initial use case will be the MMA work being done in Firefox to promote Focus or Klar.
(Assignee)

Comment 1

a year ago
Created attachment 8856060 [details] [review]
https://github.com/mozilla-mobile/focus/pull/54

This adds unique URL schemes for Focus and Klar.

* `firefox-focus://`
* `firefox-klar://`
Assignee: nobody → sarentz
Attachment #8856060 - Flags: review?(bmunar)
Attachment #8856060 - Flags: feedback?(sdaswani)
(Assignee)

Updated

a year ago
Status: NEW → ASSIGNED

Comment 2

a year ago
Looks good to me - happy to r+.
(Assignee)

Comment 4

a year ago
I added a little test app here:

  https://github.com/st3fan/FocusKlarSchemeTest

I only got this to work when I added the following to the Info.plist:

<key>LSApplicationQueriesSchemes</key>
<array>
  <string>firefox-klar</string>
  <string>firefox-focus</string>
</array>

Even when I was running this app from the Mozilla team. So you may have to add that to Firefox too.
(Assignee)

Comment 5

a year ago
Patch landed.
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
(Assignee)

Updated

a year ago
Version: unspecified → 3.2

Comment 6

a year ago
(In reply to Stefan Arentz [:st3fan] from comment #1)
> Created attachment 8856060 [details] [review]
> https://github.com/mozilla-mobile/focus/pull/54
> 
> This adds unique URL schemes for Focus and Klar.
> 
> * `firefox-focus://`
> * `firefox-klar://`

LGTM

Updated

a year ago
Attachment #8856060 - Flags: feedback?(sdaswani) → feedback+
You need to log in before you can comment on or make changes to this bug.