Closed
Bug 1354670
Opened 8 years ago
Closed 8 years ago
Give Focus and Klar a scheme
Categories
(Focus-iOS :: General, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: st3fan, Assigned: st3fan)
Details
(Whiteboard: Focus32)
Attachments
(1 file)
Give Focus and Klar a URL scheme. We don't have to handle incoming URLs yet. This is mainly to let Firefox detect is Focus or Klar is installed. Initial use case will be the MMA work being done in Firefox to promote Focus or Klar.
|
Assignee | |
Comment 1•8 years ago
|
||
This adds unique URL schemes for Focus and Klar.
* `firefox-focus://`
* `firefox-klar://`
Assignee: nobody → sarentz
Attachment #8856060 -
Flags: review?(bmunar)
Attachment #8856060 -
Flags: feedback?(sdaswani)
|
|
Assignee | |
Updated•8 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8856060 [details] [review]
https://github.com/mozilla-mobile/focus/pull/54
yayz
Attachment #8856060 -
Flags: review?(bmunar) → review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
I added a little test app here:
https://github.com/st3fan/FocusKlarSchemeTest
I only got this to work when I added the following to the Info.plist:
<key>LSApplicationQueriesSchemes</key>
<array>
<string>firefox-klar</string>
<string>firefox-focus</string>
</array>
Even when I was running this app from the Mozilla team. So you may have to add that to Firefox too.
|
|
Assignee | |
Comment 5•8 years ago
|
||
Patch landed.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•8 years ago
|
Version: unspecified → 3.2
(In reply to Stefan Arentz [:st3fan] from comment #1)
> Created attachment 8856060 [details] [review]
> https://github.com/mozilla-mobile/focus/pull/54
>
> This adds unique URL schemes for Focus and Klar.
>
> * `firefox-focus://`
> * `firefox-klar://`
LGTM
Attachment #8856060 -
Flags: feedback?(sdaswani) → feedback+
You need to log in
before you can comment on or make changes to this bug.
Description
•