1354736 - Setup WNP for Firefox 53.0 release

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, enhancement, P1)

Description

[Eric Renaud [:erenaud]]

Hello again Rail,

Please find this request to turn on WNP in Firefox 53.0 release.

We have a request to enable the /whatsnew page when desktop Firefox 53.0 ships to release.

In 1312551 , the request to show WNP in 50.0, there was the stated nuance of setting the URL to https://www.mozilla.org/%LOCALE%/firefox/50.0/whatsnew where %LOCALE% will be substituted by the updater. I wanted to be sure we captured that, updating the release # accordingly, in this request.

Please let me know if this request comes soon enough to make the 53 launch, as well as letting me know of any questions.

Comment 1

[Liz Henry (:lizzard)]

Do we need to do anything here in-product? Just for en-US or is this localized ?

Comment 2

[Liz Henry (:lizzard)]

Here are some examples:
https://www.mozilla.org/en-US/firefox/53.0/whatsnew/
https://www.mozilla.org/fr/firefox/53.0/whatsnew/

Would the right timing be to test it after merge day? Or when would be logical? I'm not clear how this works. It also sounds like we expect a WNP for some locales but not for others. For mobile also or only for Desktop?

Andrei - heads up that we have a What's New page and it will need testing at some point before release.

Comment 3

[Liz Henry (:lizzard)]

Eric, considering we went through this in https://bugzilla.mozilla.org/show_bug.cgi?id=1341100#c9 and the Italian WNP still may not be correct, what is different this time around?

Comment 4

[Liz Henry (:lizzard)]

This may have more details useful in testing and it sounds like jpetto is fixing some text for various locales. https://bugzilla.mozilla.org/show_bug.cgi?id=1302246

Comment 5

[[e-mail]]

@liz, I dont think the Italian version was not correct, its just not optimized.

Currently the italian page says "download firefox" and provides the Google Play and App Store download links.  So, as you can image, its not the best experience.  We're looking to update this page to provide more context and say:

"Your Firefox is up to date.  Now get on the go.  Download Firefox for your smartphone and tablet."

The ultimate goal of this page is to create awareness of our Firefox mobile app and increase Firefox mobile downloads.  The existing page does so, though can and will be improved.

We should move forward with all the existing pages.  As you mentioned, Jpetto will be rolling out the new pages with the new copy as they are available.

Comment 6

[Eric Renaud [:erenaud]]

I was on IRC w. liz, we're 'good' here and acknowledged that jpetto is working on updates to the pages for the improvements to copy.

Comment 7

[[e-mail]]

Thanks for the follow up Eric!  Looking forward to see the new download numbers.

Comment 8

[[e-mail]]

Liz,

Can you confirm the WNPs are live for the 53 release?  Im not seeing any installs come in.

Comment 9

[Liz Henry (:lizzard)]

That's good, because we don't release 53 until tomorrow morning, around 9am Pacific Time!

Comment 10

[[e-mail]]

DOH!  I knew we pushed the launch one day, but for some reason I thought it was Wednesday.  Thanks!!

Comment 11

[Johan Lorenzo [:jlorenzo]]

Following the instructions at [1], I created 2 new rules on:
* release-localtest https://aus4-admin.mozilla.org/rules/576
* release-cdntest https://aus4-admin.mozilla.org/rules/577

I'm syncing with QE to see if we can verify whether the correct page is open on release-cdntest. 

[1] https://wiki.mozilla.org/Release:Release_Automation_on_Mercurial:Updates_through_Shipping#Set-up_whatsnew_page

Comment 12

[Andrei Vaida [:avaida]]

e finished testing this on the release-cdntest update channel, but all of our tests failed either because
the What's New Page is _not_ displayed or because its URL is not formed correctly, here's what I mean:

      * no What's New Page displayed for (e.g.) 52.0.2-win32-en-US, 51.0-win64-fr


      * What's New Page URL is not formed correctly for (e.g.) 47.0.1-win32-en-GB, 49.0.2-win64-es-ES, 
        51.0-win64-gl, 48.0.2-win64-de, 51.0-win64-fr, 52.0.2-win32-zh-TW, 50.0.1-mac-pl

          - this is exactly how it looks like for 49.0.2-win64-es-ES:
            https://www.mozilla.org/es-ES/firefox/$VERSION/whatsnew/?oldversion=49.0.2

          - or for 51.0-win64-gl:
            https://www.mozilla.org/gl/firefox/$VERSION/whatsnew/?oldversion=51.0


Detailed test results are available here: https://public.etherpad-mozilla.org/p/wnp-fx53.

Comment 13

[Johan Lorenzo [:jlorenzo]]

Oops, I updated [1] with the right variable substitution. I also updated the wiki instructions with it. Andrei told me on IRC, QE is going to try it again.

[1] https://aus4-admin.mozilla.org/releases/Firefox-53.0-build6-whatsnew

Comment 14

[Andrei Vaida [:avaida]]

Per my conversation with :jlorenzo on IRC, the page URL is now formatted correctly, (e.g.) 48.0.2-win64-de [1], but the first issue I mentioned in Comment 12 is still unresolved -- 52.0.2-win32-en-US for example is not displaying the What's New Page after the update.


[1] https://www.mozilla.org/de/firefox/53.0/whatsnew/?oldversion=48.0.2

Comment 15

[Liz Henry (:lizzard)]

Sounds like we should not activate this page yet for 53. Let's work out the issues and then ask for re-testing and for releng to activate the page.

Comment 16

[[e-mail]]

+jpetto who can help troubleshoot these pages.

Comment 17

[Liz Henry (:lizzard)]

At this point the www team has pushed its fixes for the blocking issues and signed off in bug 1355333.  
The remaining issues for some locales will be improved gradually as we get new l10n, according to Mike Han. 
So we are OK to activate the WNP. I'll let releng know.

Comment 18

[[e-mail]]

liz,  can you confirm that any of the 53.x (dot) releases will also have the what new page?

Comment 19

[Liz Henry (:lizzard)]

We have a fennec dot release coming later this week, 53.0.1 (build 2). No desktop release planned yet.

Rail, or jpetto, how does the WNP work for Fennec dot releases? Is there something you do for this when we release, or would it be covered already for any 53.X (non esr) release?

Comment 20

[Rail Aliiev [:rail]]

I don't exactly know how we enable WNP in Fennec, but suspect this is something in-product, because we do not serve updates using Balrog.

Comment 21

[Jonathan Petto [:jpetto]]

On the bedrock/mozilla.org side, we've never (afaik) had a /whatsnew page for fennec. We do have release notes, which are regularly fed in from an external source, e.g.:

https://www.mozilla.org/firefox/android/53.0/releasenotes/

FWIW, our /whatsnew URLs follow the pattern of:

/firefox/%VERSION%/whatsnew/

That URL is always active (e.g. https://www.mozilla.org/firefox/53.0.1/whatsnew/ or https://www.mozilla.org/firefox/104.0/whatsnew/), with content only changing when requested. From what I understand, it's up to product to open the /whatsnew URL for any particular release.

Comment 22

[Jonathan Petto [:jpetto]]

To add a little more context to the above (probably too much for this particular bug, but may be helpful in the future), in bedrock we look at the %VERSION% value in the URL to determine which template to render. We almost always do this with a %VERSION% >= X, where X is the version milestone signifying new content.

Probably easier to look at the code:

https://github.com/mozilla/bedrock/blob/master/bedrock/firefox/views.py#L434
https://github.com/mozilla/bedrock/blob/master/bedrock/firefox/views.py#L350

So, if new content is requested for a release (say 57.0), we add a conditional that will render that new content only if the %VERSION% in the URL is greater than or equal to 57.0. That new content will be rendered for all future versions until another content milestone is requested.

Comment 23

[[e-mail]]

Rail,

As jpetto mentioned, this WNP that we are referring to is only for desktop, promoting mobile. 

Liz,

So going back to the original request, Id like to make sure that the WNP shows up for the 53.x dot releases (and likely 54+ subsequent releases) for desktop.  How do we ensure this happens?

Comment 24

[Rail Aliiev [:rail]]

Ah, sorry, thought it was for mobile.

WNP setup is a manual step, so I think it'd be better to explicitly mention that we want it every release.

Comment 25

[[e-mail]]

Rail,

I can reach out for every major release, but can your team ensure that this WNP is included with every dot release?

Comment 26

[Rail Aliiev [:rail]]

Sure. We can keep it around.

And just to be sure that we are on the same page, our usual practice for WNP+dot releases is to show the WNP only to users updating from <53.0, but not to users updating from 53.0+ (because we assume they have seen the page already).

Comment 27

[[e-mail]]

Rail,  Yup, that that works!

Comment 28

[Mihai Tabara [:mtabara]⌚️GMT]

For 53.0.2 I followed this docs[1] and manually added the WNP blob as follows:

mihaitabara@mozspace:[]~/Downloads$ diff Firefox-53.0.2-build1.json Firefox-53.0.2-build1-whatsnew.json 
1a2
>     "actions": "showURL",
28c29,30
<     "name": "Firefox-53.0.2-build1", 
---
>     "name": "Firefox-53.0.2-build1-whatsnew",
>     "openURL": "https://www.mozilla.org/%LOCALE%/firefox/53.0.2/whatsnew/?oldversion=%OLD_VERSION%",

Updated the rules accordingly (rule 577) to point to new WNP.

[1]: https://wiki.mozilla.org/Release:Release_Automation_on_Mercurial:Updates_through_Shipping#Set-up_whatsnew_page

Comment 29

[Liz Henry (:lizzard)]

Rule 577 (applying to 53.0.2) is set to 100% for <53.0.  I think that should mean we are showing the WNP to any users who are updating now from Firefox 52.x or below, but not to users coming from 53.0 to 53.0.2. 

Judging from ADI, most users are already on 53.0.2, a good chunk still on 53.0 and some still on 52.X. On May 4 just before we did the dot release, most users were on 53.0 already. So I expect the WNP numbers to be more of a steady trickle in this dot release, not much of a spike. 

We can ask releng to confirm again that the rule looks right.

Andrei, can your team manually test that users from 52 on popular platforms are seeing the WNP on update to 53.0.2? Thanks!

Comment 30

[Liz Henry (:lizzard)]

(This in response to Mike Han asking why there isn't a spike for their WNP stats)

Comment 31

[Liz Henry (:lizzard)]

Actually, looking at his data I think that the spike they saw on the release of 50.1 on Nov. 28th was because we must have set the WNP update rule to show the WNP for users updating from 50.0 to 50.0.1 (which I think was not the desired behavior for a minor update/dot release)

Comment 32

[[e-mail]]

Spoke with Liz about this and we would like us to update showing the WNP for fx53.0.2 to all users (regardless if they updated from 53.0 or not) moving forward.  Thank you!

Comment 33

[Paul Silaghi, QA [:pauly]]

We tested the WNP on several platforms - https://public.etherpad-mozilla.org/p/Fx53.0.2-WNP-updates.
It seems that the WNP is displayed only for users updating from Fx < 53.0, but NOT from Fx 53.0.
Also note that the WNP looks pretty empty, it doesn't contain any info about what's new. (eg: https://www.mozilla.org/en-US/firefox/53.0.2/whatsnew/?oldversion=51.0)

Comment 34

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #29)
> Rule 577 (applying to 53.0.2) is set to 100% for <53.0.  I think that should
> mean we are showing the WNP to any users who are updating now from Firefox
> 52.x or below, but not to users coming from 53.0 to 53.0.2. 

FWIW, this is correct.

Comment 35

[Liz Henry (:lizzard)]

After some discussion on the release-drivers list we are going to continue limiting the WNP to major releases (i.e. 53.0) but not dot releases, for now.

Comment 36

[Mihai Tabara [:mtabara]⌚️GMT]

For 53.0.3 I followed this docs[1] and manually added the WNP blob as follows:

mihaitabara@mozspace:[]~/Downloads/misc$ diff Firefox-53.0.3-build1.json Firefox-53.0.3-build1-whatsnew.json 
1a2,3
>     "actions": "showURL",
>     "openURL": "https://www.mozilla.org/%LOCALE%/firefox/53.0.3/whatsnew/?oldversion=%OLD_VERSION%",
28c30
<     "name": "Firefox-53.0.3-build1", 
---
>     "name": "Firefox-53.0.3-build1-whatsnew",

Updated the rules accordingly (rule 577) to point to new WNP.

[1]: https://wiki.mozilla.org/Release:Release_Automation_on_Mercurial:Updates_through_Shipping#Set-up_whatsnew_page

Comment 37

[Mihai Tabara [:mtabara]⌚️GMT]

I think we can close this bug since it addresses WNP for 53.0 as we're getting ready to ship 55.0
Please reopen if I missed anything leftover here.