Filter tab strip scrollbox overflow and underflow events more accurately

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

(Blocks 1 bug, {perf})

Trunk
Firefox 55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
I haven't seen this myself, but in theory overflow/underflow events could bubble up to <arrowscrollbox> from some anonymous element other than <scrollbox>. This could contribute to bug 1339859 among other things.

We already ignore events originating from tab elements (as of bug 658467), and we can be more explicit here by using event.originalTarget rather than event.target.
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Keywords: perf

Comment 2

2 years ago
mozreview-review
Comment on attachment 8856086 [details]
Bug 1354781 - Filter scrollbox overflow and underflow events more accurately.

https://reviewboard.mozilla.org/r/128030/#review130574

r=me as the patch looks reasonable, and I assume you have verified locally that this doesn't regress tab overflow. But I would be curious to know which elements were sending these overflow events if it wasn't the tabs (as you say they were already filtered).
Attachment #8856086 - Flags: review?(florian) → review+
Assignee

Comment 3

2 years ago
(In reply to Florian Quèze [:florian] [:flo] from comment #2)
> Comment on attachment 8856086 [details]
> Bug 1354781 - Filter scrollbox overflow and underflow events more accurately.
> 
> https://reviewboard.mozilla.org/r/128030/#review130574
> 
> r=me as the patch looks reasonable, and I assume you have verified locally
> that this doesn't regress tab overflow.

Yes.

> But I would be curious to know which
> elements were sending these overflow events if it wasn't the tabs (as you
> say they were already filtered).

Me too. Like I said it's just a theory at this point; the patch can be seen as a precautionary measure.

Comment 4

2 years ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c0e6cf04adb9
Filter scrollbox overflow and underflow events more accurately. r=florian
https://hg.mozilla.org/mozilla-central/rev/c0e6cf04adb9
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.