Closed Bug 1354850 Opened 3 years ago Closed 3 years ago

Use updater to run general app update service tests and remove gonk test code

Categories

(Toolkit :: Application Update, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox-esr52 --- fixed
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: rstrong, Assigned: rstrong)

References

Details

Attachments

(3 files, 1 obsolete file)

The general service tests should use the same method to run the general tests as the non service tests. This will simplify the test code and make it so these tests won't fail if there are changes in the application that fail. There will still be end to end testing using the non general app update tests that will still fail if there are changes in the application that fail so we shouldn't miss those failures and this should make it clear when that is the case.

Note: this should help with the recent huge increase of app update test timeouts that showed up.
Most of the recent test failures have been for the service which launches firefox.exe and this patch might very well fix the majority of those.
Summary: Use updater to run general app update service tests → Use updater to run general app update service tests and remove gonk test code
Attached patch PatchSplinter Review
Try push
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f252264fee193ac7170924a35aa3bb6a8a3d1ccf

Win8 x64 Debug try push with --tag appupdate. This way the tests runs are fast so the cost of a bunch of retriggers is reduced. Hope the try syntax works as it is supposed to.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0cf9605909256e7f3380c6dfffdc0fdf110a5c67
Attachment #8856203 - Attachment is obsolete: true
Comment on attachment 8856208 [details] [diff] [review]
Patch

Tests looking fine. I'm also retriggering this try run a bunch of times to see if I can get it to fail
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0cf9605909256e7f3380c6dfffdc0fdf110a5c67
Attachment #8856208 - Flags: review?(mhowell)
Note to self: all but one of the recent test failures have been on Win8 x64 debug. Perhaps just disable the tests on Win8 x64 debug since these popped up out of nowhere and it may be due to slow build systems.
The one case where it failed on Win 7 debug it also failed in the same place as the Win8 x64 debug failures.

launching C:\\windows\\System32\\cmd.exe /D /Q /C c:\\slave\\test\\build\\tests\\xpcshell\\tests\\toolkit\\mozapps\\update\\tests\\unit_service_updater\\marFileInUseSuccessCompleteSvc_win\\dir.app\\firefox.exe -no-remote -test-process-updates -dump-args c:\\slave\\test\\build\\tests\\xpcshell\\tests\\toolkit\\mozapps\\update\\tests\\unit_service_updater\\marFileInUseSuccessCompleteSvc_win_app_args_log >nul

This patch makes it so the majority of tests don't call firefox.exe so I'm going to hold off on disabling these on Win8 x64 debug.
Attachment #8856208 - Flags: review?(mhowell) → review+
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e567506bd73
Test only - Bug 1354850 - Use updater to run general app update service tests and remove gonk test code. r=mhowell
After going through the logs for the failing tests I think this patch will fix all of the bugs I just added to the blocking list.

It won't fix bug 1354290 or bug 1354746 since those launch firefox.exe where the tests appear to be having an intermittent problem.
https://hg.mozilla.org/mozilla-central/rev/9e567506bd73
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.