Open Bug 1354865 Opened 4 years ago Updated 2 years ago

Intermittent browser_privatebrowsing_newtab_from_popup.js | Test timed out

Categories

(Firefox :: Private Browsing, defect, P3)

defect

Tracking

()

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Keywords: intermittent-failure, leave-open, Whiteboard: [stockwell disabled])

Attachments

(2 files)

See Also: → 1280079
Mike, looks like there's still some failures lingering in this test :(
Flags: needinfo?(mconley)
Summary: Intermittent browser/components/privatebrowsing/test/browser/browser_privatebrowsing_newtab_from_popup.js | Test timed out - → Intermittent browser/components/privatebrowsing/test/browser/browser_privatebrowsing_newtab_from_popup.js | Test timed out
andthese are picking up in frequency as well :(
this is on track for 100+ failures/week, all on windows 8 (opt/pgo/debug).  There are no changes to the manifest or test case, so I think we need to look at the test case itself:
https://dxr.mozilla.org/mozilla-central/source/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_newtab_from_popup.js?q=browser_privatebrowsing_newtab_from_popup.js&redirect_type=direct#54

I see in a log [0], this data:
01:00:41     INFO - TEST-START | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_newtab_from_popup.js
01:01:26     INFO - TEST-INFO | started process screenshot
01:01:26     INFO - TEST-INFO | screenshot: exit 0
01:01:26     INFO - Buffered messages logged at 01:00:41
01:01:26     INFO - Entering test bound test_private_popup_window_opens_private_tabs
01:01:26     INFO - Buffered messages logged at 01:00:42
01:01:26     INFO - TEST-PASS | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_newtab_from_popup.js | Opened a private browsing window. - 
01:01:26     INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "data:text/html,%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20<a%20href="%23"%20id="first"%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20onclick="window.open('data:text/html;charset=utf-8;base64,PGEgaHJlZj0iaHR0cDovL2V4YW1wbGUuY29tLyIgdGFyZ2V0PSJfYmxhbmsiCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaWQ9InNlY29uZCI+CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBOb3cgY2xpY2sgdGhpcwogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDwvYT4=',%20'_blank',%20%20%20%20%20%20%20%" line: 0}]
01:01:26     INFO - TEST-PASS | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_newtab_from_popup.js | Popup window was private. - 
01:01:26     INFO - Buffered messages finished
01:01:26     INFO - TEST-UNEXPECTED-FAIL | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_newtab_from_popup.js | Test timed out - 
01:01:26     INFO - GECKO(2488) | MEMORY STAT | vsize 2003MB | vsizeMaxContiguous 6511236MB | residentFast 355MB | heapAllocated 109MB
01:01:26     INFO - TEST-OK | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_newtab_from_popup.js | took 45051ms
01:01:26     INFO - checking window state


the related screenshot:
http://mozilla-releng-blobs.s3.amazonaws.com/blobs/autoland/sha512/9419bd079f271f4212fd65819abd83d18f14e55a33ad5b860d8775c32d6799d0856780c95f780f8d59b2f34900eaed35dd9e8b7aaec774a26df789ad4e00fa72

shows that we did click the second link, although the timeout happens most likely on line 51:
let newPrivTab = yield newTabPromise;


:mconley, can you look at this, I suspect you would be able to solve this a lot faster than me.


[0] https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=93964344&lineNumber=3482
Whiteboard: [stockwell needswork]
currently 121 failures this week, lets disable this on win8 to reduce the pain
Attachment #8862359 - Flags: review?(gbrown) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d12127072d1c
Intermittent browser/components/privatebrowsing/test/browser/browser_privatebrowsing_newtab_from_popup.js. r=gbrown
Keywords: leave-open
Whiteboard: [stockwell needswork] → [stockwell disabled]
Summary: Intermittent browser/components/privatebrowsing/test/browser/browser_privatebrowsing_newtab_from_popup.js | Test timed out → Intermittent browser_privatebrowsing_newtab_from_popup.js | Test timed out
The problem appears to be that the popup is causing a new window to open instead of a new tab. Unsure why that might be - this might be a legitimate bug that this test is finding.

Pushed some diagnostic goop to try.
I'm afraid I just don't have the time to investigate this further. Hopefully my findings in comment 16 and comment 17 are useful for the next person to take a swing (even if that's me).
Flags: needinfo?(mconley)
This is failing pretty frequently on Win8 e10s on Beta as well, for some reason.
Marking P3 for backlog.
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.