convert uses of "defer" to "new Promise" in client/webaudioeditor

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Developer Tools: Web Audio Editor
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: mkohler, Assigned: mkohler)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

8 months ago
Assignee: nobody → me
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
(Assignee)

Updated

8 months ago
Attachment #8856223 - Flags: review?(nchevobbe)

Comment 2

8 months ago
mozreview-review
Comment on attachment 8856223 [details]
Bug 1354884 - convert uses of 'defer' to 'new Promise' in client/webaudioeditor

https://reviewboard.mozilla.org/r/128170/#review130804

Almost everything is good !
Please fix the commit message and feel free to land this when TRY is green

::: commit-message-35c7b:1
(Diff revision 1)
> +Bug 1354884 - convert uses of 'defer' to 'new Promise' in client/webaudioeditor

add r=nchevobbe at the end
Attachment #8856223 - Flags: review?(nchevobbe) → review+
(Assignee)

Comment 3

7 months ago
Hi Nicolas

As far as I know autoland will add the r= automatically. I don't think I have the permission to land this myself (or it's not possible due to the remaining review issue raised?), could you please do this for me?

Cheers,
Michael
Flags: needinfo?(nchevobbe)
I pushed to TRY and will land this patch if everything is green
Flags: needinfo?(nchevobbe)
(Assignee)

Comment 5

7 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c8505c5777c8565b25fbb3d11852e3e495d2d2d&selectedJob=99315325

Looks okay-ish to me. Nicolas, what do you think?
(Assignee)

Comment 6

7 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d55c79fbeef627715563c5ec9dffe22e3d04e801

Looks very green. Nicolas, can you please land this for me? I don't have the permissions, not even through autoland.

Thanks,
Michael
Flags: needinfo?(nchevobbe)
Done, thanks Michael !
Flags: needinfo?(nchevobbe)

Comment 8

7 months ago
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/61018db8d66e
convert uses of 'defer' to 'new Promise' in client/webaudioeditor r=nchevobbe

Comment 9

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/61018db8d66e
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.