Closed Bug 1354884 Opened 3 years ago Closed 3 years ago

convert uses of "defer" to "new Promise" in client/webaudioeditor

Categories

(DevTools Graveyard :: Web Audio Editor, defect)

defect
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: mkohler, Assigned: mkohler)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → me
Status: NEW → ASSIGNED
Attachment #8856223 - Flags: review?(nchevobbe)
Comment on attachment 8856223 [details]
Bug 1354884 - convert uses of 'defer' to 'new Promise' in client/webaudioeditor

https://reviewboard.mozilla.org/r/128170/#review130804

Almost everything is good !
Please fix the commit message and feel free to land this when TRY is green

::: commit-message-35c7b:1
(Diff revision 1)
> +Bug 1354884 - convert uses of 'defer' to 'new Promise' in client/webaudioeditor

add r=nchevobbe at the end
Attachment #8856223 - Flags: review?(nchevobbe) → review+
Hi Nicolas

As far as I know autoland will add the r= automatically. I don't think I have the permission to land this myself (or it's not possible due to the remaining review issue raised?), could you please do this for me?

Cheers,
Michael
Flags: needinfo?(nchevobbe)
I pushed to TRY and will land this patch if everything is green
Flags: needinfo?(nchevobbe)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d55c79fbeef627715563c5ec9dffe22e3d04e801

Looks very green. Nicolas, can you please land this for me? I don't have the permissions, not even through autoland.

Thanks,
Michael
Flags: needinfo?(nchevobbe)
Done, thanks Michael !
Flags: needinfo?(nchevobbe)
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/61018db8d66e
convert uses of 'defer' to 'new Promise' in client/webaudioeditor r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/61018db8d66e
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.