Closed Bug 1354890 Opened 5 years ago Closed 5 years ago

convert uses of "defer" to "new Promise" in client/commandline/

Categories

(DevTools Graveyard :: Graphic Commandline and Toolbar, enhancement, P3)

enhancement

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: mkohler, Assigned: mkohler)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → me
Status: NEW → ASSIGNED
Comment on attachment 8856234 [details]
Bug 1354890 - convert uses of 'defer' to 'new Promise' in client/commandline/

https://reviewboard.mozilla.org/r/128178/#review130788

Thanks for working on this, it feels so much better without defer.
Looks good, R+ if TRY is green

::: devtools/client/commandline/test/browser_cmd_calllog.js:86
(Diff revision 1)
>  <span class="indent">>></span>    ]).then(function () {
> -      deferred.resolve();
> +        resolve();
> -    });
> +      });

nit: We could simplify this a bit:
```
.then(resolve);
```

::: devtools/client/commandline/test/browser_cmd_calllog.js:104
(Diff revision 1)
> -          helpers.setInput(options, "calllog start").then(() => {
> +              helpers.setInput(options, "calllog start").then(() => {
> -            deferred.resolve();
> +                resolve();
> +              });

nit: We could simplify this a bit:
```
helpers.setInput(options, "calllog start").then(resolve)
```

::: devtools/client/commandline/test/browser_cmd_calllog_chrome.js:93
(Diff revision 1)
>  <span class="indent">>></span>    ]).then(function () {
> -      deferred.resolve();
> +        resolve();
> -    });
> +      });

nit: We could simplify this a bit:
```
.then(resolve);
```
Attachment #8856234 - Flags: review?(nchevobbe) → review+
Comment on attachment 8856234 [details]
Bug 1354890 - convert uses of 'defer' to 'new Promise' in client/commandline/

https://reviewboard.mozilla.org/r/128178/#review130808

::: commit-message-36652:1
(Diff revision 1)
> +Bug 1354890 - convert uses of 'defer' to 'new Promise' in client/commandline/

add r=nchevobbe at the end
Hi Michael, you got R+ from Nicolas a couple of weeks ago, are you still interested in finishing that bug?
Component: Developer Tools → Developer Tools: Graphic Commandline and Toolbar
Flags: needinfo?(me)
Priority: -- → P3
(In reply to Patrick Brosset <:pbro> from comment #4)
> Hi Michael, you got R+ from Nicolas a couple of weeks ago, are you still
> interested in finishing that bug?

Yes, will do that this week. Thanks for the reminder!
Pushed to reviewboard again, just to make sure I didn't screw something up. I need to contribute more to Firefox, I always forget how to use mercurial after some time..

Also, try looks very green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=467ff95f7cafce15aa597eb9b920b01658a9c3d5
Flags: needinfo?(me) → needinfo?(nchevobbe)
let's land this
Flags: needinfo?(nchevobbe)
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3c31bae690ad
convert uses of 'defer' to 'new Promise' in client/commandline/ r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/3c31bae690ad
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.