1354890 - convert uses of "defer" to "new Promise" in client/commandline/

Status: RESOLVED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, enhancement, P3)

Comment 1

[Michael Kohler [:mkohler]]

Attachment: Bug 1354890 - convert uses of 'defer' to 'new Promise' in client/commandline/

Review commit: https://reviewboard.mozilla.org/r/128178/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128178/

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8856234 [details]
Bug 1354890 - convert uses of 'defer' to 'new Promise' in client/commandline/

https://reviewboard.mozilla.org/r/128178/#review130788

Thanks for working on this, it feels so much better without defer.
Looks good, R+ if TRY is green

::: devtools/client/commandline/test/browser_cmd_calllog.js:86
(Diff revision 1)
>  <span class="indent">>></span>    ]).then(function () {
> -      deferred.resolve();
> +        resolve();
> -    });
> +      });

nit: We could simplify this a bit:
```
.then(resolve);
```

::: devtools/client/commandline/test/browser_cmd_calllog.js:104
(Diff revision 1)
> -          helpers.setInput(options, "calllog start").then(() => {
> +              helpers.setInput(options, "calllog start").then(() => {
> -            deferred.resolve();
> +                resolve();
> +              });

nit: We could simplify this a bit:
```
helpers.setInput(options, "calllog start").then(resolve)
```

::: devtools/client/commandline/test/browser_cmd_calllog_chrome.js:93
(Diff revision 1)
>  <span class="indent">>></span>    ]).then(function () {
> -      deferred.resolve();
> +        resolve();
> -    });
> +      });

nit: We could simplify this a bit:
```
.then(resolve);
```

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8856234 [details]
Bug 1354890 - convert uses of 'defer' to 'new Promise' in client/commandline/

https://reviewboard.mozilla.org/r/128178/#review130808

::: commit-message-36652:1
(Diff revision 1)
> +Bug 1354890 - convert uses of 'defer' to 'new Promise' in client/commandline/

add r=nchevobbe at the end

Comment 4

[Patrick Brosset <:pbro>]

Hi Michael, you got R+ from Nicolas a couple of weeks ago, are you still interested in finishing that bug?

Comment 5

[Michael Kohler [:mkohler]]

(In reply to Patrick Brosset <:pbro> from comment #4)
> Hi Michael, you got R+ from Nicolas a couple of weeks ago, are you still
> interested in finishing that bug?

Yes, will do that this week. Thanks for the reminder!

Comment 6

[Michael Kohler [:mkohler]]

Pushed to reviewboard again, just to make sure I didn't screw something up. I need to contribute more to Firefox, I always forget how to use mercurial after some time..

Also, try looks very green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=467ff95f7cafce15aa597eb9b920b01658a9c3d5

Comment 7

[Michael Kohler [:mkohler]]

Comment on attachment 8856234 [details]
Bug 1354890 - convert uses of 'defer' to 'new Promise' in client/commandline/

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/128178/diff/1-2/

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

let's land this

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c31bae690ad
convert uses of 'defer' to 'new Promise' in client/commandline/ r=nchevobbe

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3c31bae690ad