1354950 - Add #[destructor_safe] attributes on functions that need it

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

The FFI binding generator has support for recognizing the #[destructor_safe] attribute on rust functions, and using [1] instead of [2] in the generated header. However we need to actually add these attributes to bindings.rs. I have a patch locally to do this.

[1] http://searchfox.org/mozilla-central/rev/eace920a0372051a11d8d275bd9b8f14f3024ecd/gfx/webrender_bindings/webrender_ffi.h#471
[2] http://searchfox.org/mozilla-central/rev/eace920a0372051a11d8d275bd9b8f14f3024ecd/gfx/webrender_bindings/webrender_ffi.h#470

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Comment 2

[Ryan Hunt [:rhunt]]

Comment on attachment 8856293 [details] [diff] [review]
Patch

Didn't know about #![feature(custom_attribute)], that's cool.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Turns out it can't be used on the release version of rust :(

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6bdcc7659a1a9edc4350cd271c1631ded0a3be5c

Comment 4

[Ryan Hunt [:rhunt]]

Hm, that's unfortunate. Another possibility would be to use doc comments [1][2] with a special identifier. Or hardcode a list that we pass to the binding generator.

[1] https://doc.rust-lang.org/book/documentation.html#doc-attributes
[2] https://dtolnay.github.io/syn/syn/struct.Attribute.html

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Using a doc comment works great, thanks for the tip!

Try push that includes the updated patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e09ddc847aae07fe343ba03ebc55afe7b00da77

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1354950 - Add a destructor_safe doc attribute as a hint to the binding generator.

Review commit: https://reviewboard.mozilla.org/r/129150/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129150/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/14070c4d46fd
Add a destructor_safe doc attribute as a hint to the binding generator. r=rhunt

Comment 8

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/14070c4d46fd