Closed
Bug 1355003
Opened 7 years ago
Closed 7 years ago
stylo: Implement shape-outside
Categories
(Core :: CSS Parsing and Computation, enhancement, P1)
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: shinglyu, Assigned: canova)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
Servo side issue: https://github.com/servo/servo/issues/15958
|
Reporter | |
Comment 1•7 years ago
|
||
|
||
Updated•7 years ago
|
Priority: -- → P1
|
|
||
Comment 2•7 years ago
|
||
Nazim, can you knock this one out? Should be pretty easy and blocks quite a number of tests.
Assignee: nobody → canaltinova
|
Assignee | |
Comment 3•7 years ago
|
||
Sure!
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8857234 [details] Bug 1355003 - stylo: Change some binding names to generalize them https://reviewboard.mozilla.org/r/129174/#review131730
Attachment #8857234 -
Flags: review?(manishearth) → review+
|
|
||
Comment 7•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8857235 [details] Bug 1355003 - stylo: Update test expectations for shape-outside https://reviewboard.mozilla.org/r/129176/#review131732 ::: servo/components/style/gecko/conversions.rs:481 (Diff revision 1) > + } > + > + // Will panic on NoBox or other GeometryBox items. > + // Ideally these would be implemented on Option<T>, > + // but coherence doesn't like that and TryFrom isn't stable > + impl From<StyleGeometryBox> for ShapeBox { Can this instead be a function that returns Option? It's fine if you don't use From.
Attachment #8857235 -
Flags: review?(manishearth) → review+
|
|
||
Comment 8•7 years ago
|
||
You'll also need to update expectations. I did a try push (Automation > Trigger try on mozreview), https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c4046f50e7d I have a script that can help update reftest expectations in bulk if you need it.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 11•7 years ago
|
||
Servo side: https://github.com/servo/servo/pull/16384 > Can this instead be a function that returns Option? It's fine if you don't use From. Oh, I wrote this impl because it was implemented for `GeometryBox` but it looks like it's not needed for this change. I just removed it. Also added a commit for test expectations.
|
||
Comment 12•7 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s aa95673a15d9 -d b1e0a9bc3655: rebasing 389545:aa95673a15d9 "Bug 1355003 - stylo: Change some binding names to generalize them r=manishearth" merging layout/style/ServoBindings.cpp merging layout/style/ServoBindings.h rebasing 389546:6bb63b2cb4c6 "Bug 1355003 - stylo: Update test expectations for shape-outside r=manishearth" (tip) merging layout/style/test/stylo-failures.md warning: conflicts while merging layout/style/test/stylo-failures.md! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
|
||
Comment 13•7 years ago
|
||
Pushed by manishearth@gmail.com: https://hg.mozilla.org/integration/autoland/rev/2eeb5637d6b2 stylo: Change some binding names to generalize them r=Manishearth https://hg.mozilla.org/integration/autoland/rev/bfcf26eb6590 stylo: Update test expectations for shape-outside; r=Manishearth
|
||
Comment 14•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2eeb5637d6b2 https://hg.mozilla.org/mozilla-central/rev/bfcf26eb6590
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•