Closed Bug 1355076 Opened 7 years ago Closed 7 years ago

return information about required signoffs along with Rules, Releases, and Permissions

Categories

(Release Engineering Graveyard :: Applications: Balrog (backend), enhancement, P3)

Product:
Release Engineering Graveyard
Component:
Applications: Balrog (backend)
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: glasserc, Mentored)

References

Details

(Whiteboard: [lang=python][ready]) 

Bugs 1343915 and 1355074 have ideas about how to improve the primary Balrog UI when Required Signoffs are enabled. To support those, we need to return information about what signoffs are required for a particular object when we build the Rules, Releases, and Permissions UI. Ideally, it would be the same "required_signoffs" structure that is returned along with Scheduled Changes (https://github.com/mozilla/balrog/blob/master/auslib/admin/views/scheduled_changes.py#L62).
Mentor: bhearsum
Assignee: nobody → eglassercamp
If I understood this correctly, this doesn't cover new rules or releases, so those modals will still not offer information about whether the user's input will require signoff. This also doesn't cover signoffs that are introduced by the user changing it to a channel that requires signoffs.
(In reply to Ethan Glasser-Camp (:glasserc) from comment #1)
> If I understood this correctly, this doesn't cover new rules or releases, so
> those modals will still not offer information about whether the user's input
> will require signoff. This also doesn't cover signoffs that are introduced
> by the user changing it to a channel that requires signoffs.

These are both good points. Perhaps instead (or in addition) we need a way to grab all of the required signoffs?
I think we can close this now -- we only return required signoffs with Releases, because every other object's signoffs are derived based on what it's going to be changed to.
(In reply to Ethan Glasser-Camp (:glasserc) from comment #3)
> I think we can close this now -- we only return required signoffs with
> Releases, because every other object's signoffs are derived based on what
> it's going to be changed to.

Indeed, thank you for your work here!
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Release Engineering → Release Engineering Graveyard
You need to log in before you can comment on or make changes to this bug.