1355118 - Remove OS X static analysis builds, since clang plugin is enabled in osx cross builds

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[(not currently active) Ted Mielczarek]

The macosx64-st-an/{opt,debug} Taskcluster builds effectively duplicate the build config of the macosx64/{opt,debug} Taskcluster builds:
https://dxr.mozilla.org/mozilla-central/rev/45692c884fdd5136a64fb2f8a61a0c8183b69331/taskcluster/ci/static-analysis/kind.yml#21
https://dxr.mozilla.org/mozilla-central/rev/45692c884fdd5136a64fb2f8a61a0c8183b69331/build/macosx/cross-mozconfig.common#51

These were added in bug 1264494, but bug 1208787 enabled the clang plugin in the cross-mac builds. It's unfortunate that nobody realized this earlier, since we could have saved all the work done in bug 1264494 and just turned off the buildbot builds. In any event, we can turn off the mac static analysis builds that run in Taskcluster and save ourselves some cycles. This should simply involve removing those entries from kind.yml.

Comment 1

[(not currently active) Ted Mielczarek]

Also this is currently making our build times data bimodal:
https://mzl.la/2vf2HCP

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1355118 - Remove OS X static analysis builds.

Since clang plugin is enabled in osx cross builds.

Review commit: https://reviewboard.mozilla.org/r/158570/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158570/

Comment 3

[Gregory Szorc [:gps]]

Oh, I've been meaning to look into why the build data was bimodal!

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8887679 [details]
Bug 1355118 - Remove OS X static analysis builds.

https://reviewboard.mozilla.org/r/158570/#review163858

::: taskcluster/ci/static-analysis/kind.yml
(Diff revision 1)
> -            actions: [build update]
> -            config:
> -                - builds/releng_base_mac_64_cross_builds.py
> -                - balrog/production.py
> -            # enables static analysis.
> -            custom-build-variant-cfg: cross-debug-st-an

Can we remove the reference to this build variant in testing/mozharness/mozharness/mozilla/building/buildbase.py and the files from testing/mozharness/configs/builds/releng_sub_mac_configs?

Comment 5

[Mike Hommey [:glandium]]

Heh, I looked at the other things, that ended up still being used by other jobs, but skipped the mozharness build variants.

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 8887679 [details]
Bug 1355118 - Remove OS X static analysis builds.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158570/diff/1-2/

Comment 7

[Gregory Szorc [:gps]]

Comment on attachment 8887679 [details]
Bug 1355118 - Remove OS X static analysis builds.

https://reviewboard.mozilla.org/r/158570/#review163878

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0d9a951b1c6
Remove OS X static analysis builds. r=gps

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e0d9a951b1c6