Closed
Bug 1355183
Opened 8 years ago
Closed 8 years ago
Make WrExternalImageType repr(u32)
Categories
(Core :: Graphics: WebRender, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
It's currently marked repr(C) which is for structs. But it's an enum. For FFI safety we should mark it repr(u32)
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•8 years ago
|
||
Try push that includes this change: https://treeherder.mozilla.org/#/jobs?repo=try&revision=42a18a23b2528246f2c33d6af3581589eb40a4cd
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8856660 [details]
Bug 1355183 - Mark WrExternalImageType as repr(u32) instead of repr(C).
https://reviewboard.mozilla.org/r/128586/#review131062
Attachment #8856660 -
Flags: review?(rhunt) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/5b98a41fea59
Mark WrExternalImageType as repr(u32) instead of repr(C). r=rhunt
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•8 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•8 years ago
|
status-firefox55:
--- → fixed
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•