Note: There are a few cases of duplicates in user autocompletion which are being worked on.

FindProxyForURL "DIRECT" return type should not expect an argument

RESOLVED FIXED in Firefox 56

Status

()

Toolkit
WebExtensions: Request Handling
RESOLVED FIXED
3 months ago
a month ago

People

(Reporter: mattw, Assigned: mattw)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

unspecified
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [proxy] triaged)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 months ago
Currently, if "DIRECT" is returned by FindProxyForURL, the following error is thrown: "FindProxyForURL: Invalid Proxy Rule: DIRECT". This is because the function which parses the proxy rules expects every rules to have an argument (e.g. "PROXY 1.2.3.4:8080").
Comment hidden (mozreview-request)

Comment 2

3 months ago
mozreview-review
Comment on attachment 8857217 [details]
Bug 1355198 - Fix DIRECT return type to take no arguments and update error handling

https://reviewboard.mozilla.org/r/128934/#review132596
Attachment #8857217 - Flags: review?(mixedpuppy) → review+
Comment hidden (mozreview-request)
(Assignee)

Updated

3 months ago
Keywords: checkin-needed

Comment 4

3 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ddcbb81610fd
Fix "DIRECT" return type to take no arguments and update error handling r=mixedpuppy
Keywords: checkin-needed
Backed out in https://hg.mozilla.org/integration/autoland/rev/35c773084736 for Android debug bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=94646659&repo=autoland
(Assignee)

Updated

2 months ago
Assignee: nobody → mwein
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 8

a month ago
Pushed by mwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b485d626fb51
Fix DIRECT return type to take no arguments and update error handling r=mixedpuppy
https://hg.mozilla.org/mozilla-central/rev/b485d626fb51
Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Depends on: 1357635
You need to log in before you can comment on or make changes to this bug.