FindProxyForURL "DIRECT" return type should not expect an argument

RESOLVED FIXED in Firefox 56

Status

RESOLVED FIXED
2 years ago
5 months ago

People

(Reporter: mattw, Assigned: mattw)

Tracking

(Blocks: 1 bug, {dev-doc-complete})

unspecified
mozilla56
dev-doc-complete
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [proxy] triaged)

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Currently, if "DIRECT" is returned by FindProxyForURL, the following error is thrown: "FindProxyForURL: Invalid Proxy Rule: DIRECT". This is because the function which parses the proxy rules expects every rules to have an argument (e.g. "PROXY 1.2.3.4:8080").
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8857217 [details]
Bug 1355198 - Fix DIRECT return type to take no arguments and update error handling

https://reviewboard.mozilla.org/r/128934/#review132596
Attachment #8857217 - Flags: review?(mixedpuppy) → review+
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 4

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ddcbb81610fd
Fix "DIRECT" return type to take no arguments and update error handling r=mixedpuppy
Keywords: checkin-needed
(Assignee)

Updated

2 years ago
Assignee: nobody → mwein
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 8

a year ago
Pushed by mwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b485d626fb51
Fix DIRECT return type to take no arguments and update error handling r=mixedpuppy
https://hg.mozilla.org/mozilla-central/rev/b485d626fb51
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Depends on: 1357635
Docs still mention this bug.
Keywords: dev-doc-needed
Thanks for flagging this one. I've updated https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/proxy#PAC_file_environment which I think is the only place that mentions the bug.
Keywords: dev-doc-needed → dev-doc-complete

Updated

5 months ago
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.