1355198 - FindProxyForURL "DIRECT" return type should not expect an argument

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, defect)

Description

[Matthew Wein [:mattw]]

Currently, if "DIRECT" is returned by FindProxyForURL, the following error is thrown: "FindProxyForURL: Invalid Proxy Rule: DIRECT". This is because the function which parses the proxy rules expects every rules to have an argument (e.g. "PROXY 1.2.3.4:8080").

Comment 1

[Matthew Wein [:mattw]]

Attachment: Bug 1355198 - Fix DIRECT return type to take no arguments and update error handling

Review commit: https://reviewboard.mozilla.org/r/128934/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128934/

Comment 2

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8857217 [details]
Bug 1355198 - Fix DIRECT return type to take no arguments and update error handling

https://reviewboard.mozilla.org/r/128934/#review132596

Comment 3

[Matthew Wein [:mattw]]

Comment on attachment 8857217 [details]
Bug 1355198 - Fix DIRECT return type to take no arguments and update error handling

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/128934/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ddcbb81610fd
Fix "DIRECT" return type to take no arguments and update error handling r=mixedpuppy

Comment 5

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/autoland/rev/35c773084736 for Android debug bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=94646659&repo=autoland

Comment 6

[Matthew Wein [:mattw]]

Comment on attachment 8857217 [details]
Bug 1355198 - Fix DIRECT return type to take no arguments and update error handling

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/128934/diff/2-3/

Comment 7

[Matthew Wein [:mattw]]

Comment on attachment 8857217 [details]
Bug 1355198 - Fix DIRECT return type to take no arguments and update error handling

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/128934/diff/3-4/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b485d626fb51
Fix DIRECT return type to take no arguments and update error handling r=mixedpuppy

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b485d626fb51

Comment 10

[Shane Caraveo (:mixedpuppy)]

Docs still mention this bug.

Comment 11

[Will Bamberg [:wbamberg]]

Thanks for flagging this one. I've updated https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/proxy#PAC_file_environment which I think is the only place that mentions the bug.