FindProxyForURL "DIRECT" return type should not expect an argument

NEW
Unassigned

Status

()

Toolkit
WebExtensions: Request Handling
15 days ago
12 days ago

People

(Reporter: mattw, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [proxy] triaged)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

15 days ago
Currently, if "DIRECT" is returned by FindProxyForURL, the following error is thrown: "FindProxyForURL: Invalid Proxy Rule: DIRECT". This is because the function which parses the proxy rules expects every rules to have an argument (e.g. "PROXY 1.2.3.4:8080").
Comment hidden (mozreview-request)

Comment 2

12 days ago
mozreview-review
Comment on attachment 8857217 [details]
Bug 1355198 - Fix "DIRECT" return type to take no arguments and update error handling

https://reviewboard.mozilla.org/r/128934/#review132596
Attachment #8857217 - Flags: review?(mixedpuppy) → review+
You need to log in before you can comment on or make changes to this bug.