Closed Bug 1355198 Opened 3 years ago Closed 2 years ago

FindProxyForURL "DIRECT" return type should not expect an argument

Categories

(WebExtensions :: Request Handling, defect)

defect
Not set

Tracking

(firefox56 fixed)

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: mattw, Assigned: mattw)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete, Whiteboard: [proxy] triaged)

Attachments

(1 file)

Currently, if "DIRECT" is returned by FindProxyForURL, the following error is thrown: "FindProxyForURL: Invalid Proxy Rule: DIRECT". This is because the function which parses the proxy rules expects every rules to have an argument (e.g. "PROXY 1.2.3.4:8080").
Comment on attachment 8857217 [details]
Bug 1355198 - Fix DIRECT return type to take no arguments and update error handling

https://reviewboard.mozilla.org/r/128934/#review132596
Attachment #8857217 - Flags: review?(mixedpuppy) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ddcbb81610fd
Fix "DIRECT" return type to take no arguments and update error handling r=mixedpuppy
Keywords: checkin-needed
Assignee: nobody → mwein
Pushed by mwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b485d626fb51
Fix DIRECT return type to take no arguments and update error handling r=mixedpuppy
https://hg.mozilla.org/mozilla-central/rev/b485d626fb51
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Depends on: 1357635
Docs still mention this bug.
Keywords: dev-doc-needed
Thanks for flagging this one. I've updated https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/proxy#PAC_file_environment which I think is the only place that mentions the bug.
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.