1355248 - Be lazier about a few imports in LoginManagerContent.jsm

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[Andrew McCreight [:mccr8]]

This prevents loading InsecurePasswordUtils.jsm at startup.

Comment 1

[Andrew McCreight [:mccr8]]

Currently InsecurePasswordUtils.jsm is loaded both eagerly and lazily by LoginManagerContent.jsm, for some reason.

Comment 2

[Andrew McCreight [:mccr8]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4710db9ab9fc1b45d631ec2d5d11e0f0f128b51b&filter-tier=1

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1355248 - Don't eagerly import InsecurePasswordUtils.jsm in LoginManagerContent.jsm.

Review commit: https://reviewboard.mozilla.org/r/128922/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128922/

Comment 4

[Matthew N. [:MattN]]

Comment on attachment 8857030 [details]
Bug 1355248 - Don't eagerly import InsecurePasswordUtils.jsm in LoginManagerContent.jsm.

https://reviewboard.mozilla.org/r/128922/#review131500

Thanks

::: toolkit/components/passwordmgr/LoginManagerContent.jsm:30
(Diff revision 1)
> +XPCOMUtils.defineLazyModuleGetter(this, "PrivateBrowsingUtils",
> +				  "resource://gre/modules/PrivateBrowsingUtils.jsm");

The guideline before was to not bothering using a lazy module getter if you know it will be imported shortly after the importer is loaded. For PrivateBrowsingUtils it gets used on every page load if pwmgr is on (it is by default) so this would only help people with pwmgr off assuming other modules don't import it eagerly (I think most do and is the reason why it's done eagerly here too). E10s changed which processes modules are imported in though so it's possible that it's not always imported already in the content process.

Comment 5

[Andrew McCreight [:mccr8]]

That's a good point. I'll just remove that part of the patch. There's another place that loads it so I'm sure it will be around anyways.

Comment 6

[Andrew McCreight [:mccr8]]

Comment on attachment 8857030 [details]
Bug 1355248 - Don't eagerly import InsecurePasswordUtils.jsm in LoginManagerContent.jsm.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/128922/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9d7467de823
Don't eagerly import InsecurePasswordUtils.jsm in LoginManagerContent.jsm. r=MattN

Comment 8

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/b9d7467de823